Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Higher Order Component for Popups #3089

Closed
iMerica opened this issue Aug 16, 2018 · 2 comments
Closed

Feature: Higher Order Component for Popups #3089

iMerica opened this issue Aug 16, 2018 · 2 comments
Labels

Comments

@iMerica
Copy link

iMerica commented Aug 16, 2018

Hey guys,

Loving this library. Thanks for working on it!

Feature Request

It would be great if we can write popups like this:

<PopUp>
  <Form.Field .... />
</PopUp>

Problem description

Popups work fine right now, but passing in that much JSX as props is a messy API.

Proposed solution

Stage One:
Popups as a separate HOC.
Stage Two:
HOC Popups as the default API

MVP

I'll post a branch once I get it working

@welcome
Copy link

welcome bot commented Aug 16, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

Duplciate #2552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants