Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development reload issues #3095

Closed
levithomason opened this issue Aug 20, 2018 · 1 comment · Fixed by #3098
Closed

Local development reload issues #3095

levithomason opened this issue Aug 20, 2018 · 1 comment · Fixed by #3098
Assignees

Comments

@levithomason
Copy link
Member

@layershifter I've noticed after the latest round of build changes that editing an example source file in watch mode does not work correctly. The exampleSources.json gets rewritten with only a single example entry, so all the other examples are missing. Perhaps you could take a look?

Steps

  1. yarn start

  2. Navigate to /elements/button

  3. See all examples are rendered and exampleSources.json includes all examples

  4. Edit ButtonExampleButton.js

  5. 🐞 There is no HMR or page reload

  6. 🐞 exampleSources.json now looks like this:

    {
      "elements/Button/Types/ButtonExampleButton": "import React from 'react'\nimport { Button } from 'semantic-ui-react'\n\nconst ButtonExampleButton = () => <Button>Click Here!</Button>\n\nexport default ButtonExampleButton\n"
    }

Initial Load

image

After editing ButtonExampleButton.js

image

@layershifter
Copy link
Member

💥 Will take a look tomorrow, @levithomason your reports are awesome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants