-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown doesn't close when placed inside of Checkbox component #4036
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
@tuyakhov it seems that it comes from these lines: Semantic-UI-React/src/modules/Dropdown/Dropdown.js Lines 414 to 416 in bf87dd2
I suggest to check what will happen if these lines will be simply removed. I don't that a comment there is still relevant. |
An ugly workaround to unblock you: https://codesandbox.io/s/wizardly-thompson-w03wb?file=/example.js. Please let us know if works for you |
Hi @layershifter , |
https://www.npmjs.com/package/patch-package should work for you, can you please try? Semantic-UI-React/src/modules/Dropdown/Dropdown.js Lines 453 to 454 in bf87dd2
Actually it seems that these lines are the source of the issue. |
I could help with this one if needed. Here is my initial plan of how to fix this. const { open } = this.state
if(!open) {
e.stopPropagation()
} What do you think? |
we had the same issue, the workaround did solve it although we ended up just moving things in the design at the end less complexity |
Bug Report
Steps
Expected Result
The dropdown menu should close
Actual Result
It remains open until you click on one of the options one more time or click outside of the menu
Version
1.2.0
Testcase
https://codesandbox.io/s/vigorous-ives-l0qwm?file=/example.js
The text was updated successfully, but these errors were encountered: