Inconsistency with widescreen only class
#3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed the mobile rules are repeated for widescreen, and the other fixes mentioned. |
jlukic
added a commit
that referenced
this pull request
Oct 14, 2015
Inconsistency with `widescreen only` class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid
row/columnclasses use thewidescreen onlyselector, however in the parentgridclass onlywidescreenis present (missingonly). Also, in the mobile only hide, therow/columnwidescreen onlyis missing, withlarge screen onlyrepeated twice (probably simply a forgotten find/replace after a copy/paste).Additionally switches the tablet only class selector on the mobile only hide from
.tablet:not(.mobile).onlyto[class*="tablet only"]:not(.mobile), for consistency with the surrounding selectors.