Ability to cancel a modal hide from the onHide callback #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
changed the title
|
I don't see any downsides to this. |
jlukic
added a commit
that referenced
this pull request
Oct 14, 2015
Ability to cancel a modal hide from the onHide callback
mdehoog
added a commit
to mdehoog/Semantic-UI-Docs
that referenced
this pull request
Oct 14, 2015
|
Thanks @jlukic. PR to update the docs for this change has been submitted. You've done a fantastic job with this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the modal allows the user to cancel a hide from the
onDenyandonApprovecallbacks, but not from theonHide. This could be useful if you want to stop the user from hiding a modal but don't want to setclosableto false.For example, if you have a popup that submits a request to the server, and you want to display a loading state after the user has submitted, you could temporarily disable closing the popup by returning false from the
onHidecallback while the form submission is in progress.Happy to also create a PR for the docs repository documenting this change.