Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR produces a server error on success #4908

Open
wrycu opened this issue Jan 13, 2017 · 6 comments
Open

XHR produces a server error on success #4908

wrycu opened this issue Jan 13, 2017 · 6 comments

Comments

@wrycu
Copy link

wrycu commented Jan 13, 2017

If the server returns a 2xx or 3xx code that is not 200, Semantic UI flags the response as an error. 2xx (in particular 201 - Created) is a valid success response code and should not be considered an error.

else if(status == 'error') {
    if(xhr !== undefined) {
      module.debug('XHR produced a server error', status, httpMessage);
      // make sure we have an error to display to console
      if( xhr.status != 200 && httpMessage !== undefined && httpMessage !== '') {
        module.error(error.statusMessage + httpMessage, ajaxSettings.url);
      }
      settings.onError.call(context, errorMessage, $module, xhr);
    }
}
@wrycu wrycu changed the title XHR produced a server error on success XHR produces a server error on success Jan 13, 2017
@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@wrycu
Copy link
Author

wrycu commented Feb 23, 2018

Still an issue.

Not a huge fan of ignoring issues for a year, then marking them stale and closing them.

@stale stale bot removed the stale label Feb 23, 2018
@stale
Copy link

stale bot commented May 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 24, 2018
@brodycj
Copy link

brodycj commented May 24, 2018

??

@stale stale bot removed the stale label May 24, 2018
@wrycu
Copy link
Author

wrycu commented Feb 17, 2019

Any progress here? It's been two years for a several character fix.

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants