[Popup] Possible error in popup module's supports.svg() function

[davidlav]

In trying to get Semantic UI popups to work on d3 elements, I found a possible error in the function that checks for browser support of SVGGraphicsElement.

A prior bug report (#3043) explained that Semantic UI checks for browser support of the SVGGraphicsElement before allowing a popup over one to be created. I believe the current function returns the opposite of what it ought to:

supports: {
          svg: function() {
            return (typeof SVGGraphicsElement === undefined);
          }
        }

The above function returns false when SVGGraphicsElements do exist. The equality operator should be an inequality operator instead.

supports: {
          svg: function() {
            return (typeof SVGGraphicsElement !== undefined);
          }
        }

When I change === to !== my popups are created and work as they should.

[awgv]

Hi @davidlav, thank you, the maintainer will take a look. Linking the original issue here: #3043.

[Tweety79rw]

I noticed this bug September 2016, but I guess I didn't follow the contributing guide well enough. Here is the pull request #4517

[stale]

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!