Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Change \35 00px class name #5468

Open
nhanco opened this issue Jun 16, 2017 · 6 comments
Open

[Icon] Change \35 00px class name #5468

nhanco opened this issue Jun 16, 2017 · 6 comments

Comments

@nhanco
Copy link

nhanco commented Jun 16, 2017

I'm using semantic ui with Pug js template. And the prolem i got is the class name 500px. They only accept class names begin with "-", "_" or a letter. That really easy to fix, but if a official fix is better.

@awgv
Copy link
Member

awgv commented Jun 16, 2017

Hi @nhanco, SUI doesn’t have a class with that name.

@awgv awgv closed this as completed Jun 16, 2017
@nhanco
Copy link
Author

nhanco commented Jun 16, 2017

See document for 500px icon.

@awgv
Copy link
Member

awgv commented Jun 16, 2017

@nhanco I apologize, I did a quick search, but wasn’t aware that the class name was escaped as \35 00px. Can you use escaped classes with Pug.js?

@nhanco
Copy link
Author

nhanco commented Jun 16, 2017

No you can't use that class name on Pug.js. I was write a new class i.icon.fix500px:before ,then all run smooth. The reason i start this post is make the team know that class name is not good.

@awgv
Copy link
Member

awgv commented Jun 16, 2017

@nhanco Alright, Wikipedia says the service is pronounced as “five hundred px”, I see no reason to keep it escaped, and will open a PR as soon as I can.

@awgv awgv reopened this Jun 16, 2017
@awgv awgv changed the title change 500px class name. [Icon] Change \35 00px class name Jun 16, 2017
@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants