-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment] Add "Primary" and "Secondary" colored segments #5785
Comments
How would I make a Fun fact, there is already a |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
The idea here is to extend the colored variations to allow using primary as a color. On segments I can see how that might be confusing since there is another concept of secondary, so maybe it should stick to primary. To me it makes perfect sense to use primary for a color, it's used in other elements such as buttons, why not here? It's also defined as a color in the less. I could use an explicit color that matches my primary, but then when I change my theme from primary color orange to blue (which I'm currently doing now) I'm going to have to go refactor everywhere that I use it in my code. I would say if themes are a first-class idea in Semantic, then using the primary color should be as well since many theme changes are just tweaking colors. |
It would be useful to have a colored segment variant that has the accent in the primary and secondary brand colors.
The text was updated successfully, but these errors were encountered: