Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment] Add "Primary" and "Secondary" colored segments #5785

Open
sethmoore opened this issue Sep 13, 2017 · 4 comments
Open

[Segment] Add "Primary" and "Secondary" colored segments #5785

sethmoore opened this issue Sep 13, 2017 · 4 comments

Comments

@sethmoore
Copy link

It would be useful to have a colored segment variant that has the accent in the primary and secondary brand colors.

@witrin
Copy link

witrin commented Jan 12, 2018

How would I make a primary segment less noticeable? By calling it secondary primary segment? Sounds silly. There are already the variations secondary and tertiary for the emphasis and primary is just another ball in this pool. So they are exclusive and can't be used at the same time. I would just use the unnamed (inverted) segment as the primary variation by using @border (@invertedBackground). If you want also use secondary segment with a specific color you could just adapt its definition too.

Fun fact, there is already a primary inverted segment (see src/definitions/elements/segment.less#L651). But I would call this a bug.

@stale
Copy link

stale bot commented Apr 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2018
@sethmoore
Copy link
Author

The idea here is to extend the colored variations to allow using primary as a color. On segments I can see how that might be confusing since there is another concept of secondary, so maybe it should stick to primary. To me it makes perfect sense to use primary for a color, it's used in other elements such as buttons, why not here? It's also defined as a color in the less. I could use an explicit color that matches my primary, but then when I change my theme from primary color orange to blue (which I'm currently doing now) I'm going to have to go refactor everywhere that I use it in my code.

I would say if themes are a first-class idea in Semantic, then using the primary color should be as well since many theme changes are just tweaking colors.

@stale stale bot removed the stale label Apr 12, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants