Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Search "No Results" title is not translatable #5791

Open
indreksiitan opened this issue Sep 14, 2017 · 8 comments
Open

[Search] Search "No Results" title is not translatable #5791

indreksiitan opened this issue Sep 14, 2017 · 8 comments

Comments

@indreksiitan
Copy link

Bug: Search results "No Results" message is hardcoded:

screenshot 2017-09-14 23 13 18

Fix: move this message to the error array so it can be translated/overloaded.

@awgv
Copy link
Member

awgv commented Sep 14, 2017

Hi @indreksiitan, the templates property can easily be overriden either during the initialization, or globally with $.fn.search.settings.templates.message =.

@awgv awgv closed this as completed Sep 14, 2017
@indreksiitan
Copy link
Author

I understand that it can be, but I would still argue that it's bad to hardcode translations, especially if there is a general logic for handling those in place.

@awgv
Copy link
Member

awgv commented Sep 14, 2017

@indreksiitan We’ll take a look.

@awgv awgv reopened this Sep 14, 2017
@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@indreksiitan
Copy link
Author

This still needs a fix.

@stale stale bot removed the stale label Feb 23, 2018
@stale
Copy link

stale bot commented May 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@brunohkbx
Copy link

Why is this hardcoded?

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants