-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Search "No Results" title is not translatable #5791
Comments
Hi @indreksiitan, the templates property can easily be overriden either during the initialization, or globally with |
I understand that it can be, but I would still argue that it's bad to hardcode translations, especially if there is a general logic for handling those in place. |
@indreksiitan We’ll take a look. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
This still needs a fix. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Why is this hardcoded? |
Bug: Search results "No Results" message is hardcoded:
Fix: move this message to the error array so it can be translated/overloaded.
The text was updated successfully, but these errors were encountered: