Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Fixes #5643 Primary & Secondary Inverted Buttons #6242

Closed
wants to merge 9 commits into from

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Mar 5, 2018

Description

Primary and secondary inverted buttons display incorrectly

Expected result:
image

Actual result:
image

Fixes Issues

#5643

Testcase

https://jsfiddle.net/hammy2899/pc13yp7f/1/

@y0hami y0hami changed the base branch from master to next March 5, 2018 13:58
@jlukic jlukic added this to the 2.3.2 milestone Mar 7, 2018
@stale
Copy link

stale bot commented Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 5, 2018
@jlukic
Copy link
Member

jlukic commented Jun 18, 2018

I've added this feature using different code in 16e4942

This correlates to how other inverted and basic inverted styles are implemented and handle inheritance for some cases not available in the PR.

They also use lightPrimaryColor and lightSecondaryColor which are the variations of primary / secondary that are intended for dark bgs.

I've added the necessary corresponding state colors for these inverted colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants