Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Modals since 2.3.0 regression in Safari #6251

Closed
romaninsh opened this issue Mar 7, 2018 · 4 comments
Closed

Fullscreen Modals since 2.3.0 regression in Safari #6251

romaninsh opened this issue Mar 7, 2018 · 4 comments
Milestone

Comments

@romaninsh
Copy link

After upgrading to 2.3.0, fullscreen modal widow does not display "close" icon correctly in safari:

From: https://semantic-ui.com/modules/modal.html#/definition

screen shot 2018-03-07 at 19 08 39

Cross is still visible, but is positioned badly:

screen shot 2018-03-07 at 19 10 58

@romaninsh
Copy link
Author

Same issue in Safari Technology Preview.

@w96k
Copy link

w96k commented Mar 8, 2018

Do you have any ideas why its happening?

@y0hami
Copy link
Member

y0hami commented Mar 8, 2018

I have checked this on as many Safari versions as I can and have found that this bug goes back to Safari 9.1. There is also another bug where on earlier versions the close icon displays but is not correctly positioned.

It looks like the icon shows then it just disappears
ezgif-1-35a8f994a3

Incorrectly placed icon on >9.1
image

@jlukic jlukic added this to the 2.3.2 milestone Mar 14, 2018
@jlukic
Copy link
Member

jlukic commented Mar 14, 2018

Added milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants