Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 3.0.0 release #48

Closed
6 tasks done
kghbln opened this issue May 15, 2020 · 5 comments
Closed
6 tasks done

Make 3.0.0 release #48

kghbln opened this issue May 15, 2020 · 5 comments
Assignees

Comments

@kghbln
Copy link
Member

kghbln commented May 15, 2020

@kghbln
Copy link
Member Author

kghbln commented May 15, 2020

As a result of #47 once completed.

@kghbln kghbln self-assigned this May 15, 2020
@akuckartz
Copy link

As a result of #47 once completed.

It seems to be completed ;-)

@kghbln
Copy link
Member Author

kghbln commented Aug 7, 2020

Latest master available on sandbox for testing and extending by additional examples.

The only irritating thing I realize now it the overflow bars which we are unconditionally getting. I believe this needs to be tweaked. @cicalese I think this enhancement was originally created by you and it worked in previous releases, i.e. we got the bars only for oversized charts etc. Perhaps you have an idea as to why this is now shown unconditionally.

@cicalese
Copy link
Contributor

cicalese commented Sep 3, 2020

@kghbln I did not see the scrollbars in the examples, but they are probably due to

/** Mermaid
 * Add scrollbars to wide graphs
 */
.ext-mermaid > div {
	overflow: scroll;
}

which as introduced into MediaWiki:Common.css in https://sandbox.semantic-mediawiki.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=47241 due to #41. If you don't want to add that unconditionally, maybe you could use TemplateStyles to add it only to pages that need it?

@kghbln
Copy link
Member Author

kghbln commented Sep 4, 2020

@cicalese

I did not see the scrollbars in the examples

Hmm, probably a browser related issue. This is what Fx shows:

grafik

but they are probably due to ... which as introduced into MediaWiki:Common.css in https://sandbox.semantic-mediawiki.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=47241 due to #41

Ah, I figured this was part of the CSS shipped with the extension. That explains it. Thanks a lot for the pointer.

If you don't want to add that unconditionally, maybe you could use TemplateStyles to add it only to pages that need it?

No, since the latest release it really looks ugly, so an alternative solution probably involving a template using TemplateStyles is the best option here. Thanks again for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants