Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit version #4

Open
JeroenDeDauw opened this issue Jun 19, 2016 · 3 comments
Open

PHPUnit version #4

JeroenDeDauw opened this issue Jun 19, 2016 · 3 comments

Comments

@JeroenDeDauw
Copy link
Member

https://github.com/SemanticMediaWiki/SemanticNotifications/blob/master/.travis.yml specifies 4.8.x, which appears to be the default by looking at the relevant.sh file. Is that intended?

Any reason to not use PHPUnit >=5.4? Like this you are writing new test code with constructs already deprecated and that will be removed in PHPUnit 6.0, which is not all that far off. Most notably getMock vs createMock

@mwjames
Copy link
Contributor

mwjames commented Jun 19, 2016

Any reason to not use PHPUnit >=5.4? Like this you are writing new test code with constructs already

This last time I tried SMW with 5.4, it just blew up (big times) therefore I decided that 5.4+ has nothing of value that would justify an additional effort and its release cycle of two months or so to push an agenda of deprecations is ridiculous.

Most notably getMock vs createMock

To be honest, I find that change counter-productive (even if it represents a better intend) because for no benefit a lot of users are left (like us) to change a bunch of code, so I'm not wholeheartedly support this change.

Unless PHPUnit provides some tools to minimize the effort for such change, I just stay with ~4.8 and don't bother at all.

@mwjames
Copy link
Contributor

mwjames commented Jun 19, 2016

Same with setExpectedException (Method deprecated since Release 5.2.0) ... really !!??!!

@JeroenDeDauw
Copy link
Member Author

JeroenDeDauw commented Jun 19, 2016

Updating is really trivial.

Of course you can just stick with 4.x, which will still be maintained for some time. However that is what I would label as counter-productive :) You just shoot yourself in the foot and will no cause any change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants