Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Optimization GitHub Action #3

Open
humphd opened this issue Oct 19, 2022 · 5 comments
Open

Image Optimization GitHub Action #3

humphd opened this issue Oct 19, 2022 · 5 comments
Assignees

Comments

@humphd
Copy link
Collaborator

humphd commented Oct 19, 2022

When a user uploads their photos to be shared, we need to optimize them. I think this should include the following:

  • remove any GPS information. We might want to make this an optional thing later on, but to start, let's remove it, since most people don't know their images have tracking information in them. Something like imagemagick can do it with --strip
  • generate different sizes of each image for various common breakpoints/devices on the web
  • use various encoders (WebP, AVIF, JPG) to take advantage of newer browsers

There are probably other things we can do too.

When the optimization is done, we should have both the original photos and optimized photos in different directories.

@Genne23v
Copy link

Genne23v commented Nov 5, 2022

I would like to create a demo to do this task. I found two libraries that could do metadata extraction and image resizing.
ExifReader - Metadata extractor
Sharp - Image resizing

I'm not sure how I should implement to merge with other parts. Please let me know if you have any expectation on this issue.

@humphd
Copy link
Collaborator Author

humphd commented Nov 6, 2022

Start by creating shell scripts that can do this in Unix. When we run this, we'll do it on an Ubuntu cloud instance in GitHub Actions.

@batunpc
Copy link
Collaborator

batunpc commented Dec 2, 2022

Hi @Genne23v, I am just checking if this issue is still being worked on.

@SerpentBytes
Copy link
Collaborator

@batunpc, I have seen his blog post. I think he's working on this issue.

@Genne23v
Copy link

Genne23v commented Dec 2, 2022

@SerpentBytes Thanks for the comment! @batunpc Yes, I'm going to push something soon. Sorry for late reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants