Setup Chakra UI #75
Merged
Setup Chakra UI #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eakam1007
force-pushed
the
24-setup-chakra-ui
branch
from
d35517b to
907813f
Compare
humphd
requested changes
Jan 31, 2023
There was a problem hiding this comment.
This looks good.
Can you modify something in the https://github.com/Seneca-CDOT/starchart/blob/main/app/routes/index.tsx to use ChakraUI Components? Maybe switch to:
That will make it easier for others to test that this works.
|
I changed the index page to use the components you linked. I also added some styles to change the font size so the change should be visible now |
humphd
approved these changes
Feb 1, 2023
ghost
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Added and setup Chakra UI.
This does not involve the addition of a theme as there is a separate issue for it: #34
Also changed the index page to use Chakra UI components (with increased font sizes) so that this can be tested:
Before
After
Steps for testing
This assumes you already have starchart setup locally
npm installnpm run devlocalhost:3000and see that the app works and the index page has the updated styles