Initial schema #79
Initial schema #79
Conversation
prisma/schema.prisma
Outdated
| name String | ||
| type SubdomainType | ||
| value String | ||
| description String |
There was a problem hiding this comment.
I think that description, course, and ports should all be marked optional (i.e., add a ?). The rest can be required.
prisma/schema.prisma
Outdated
| } | ||
|
|
||
| enum SubdomainType { | ||
| CNAME |
There was a problem hiding this comment.
nit: alphabetize these, and put A first.
prisma/schema.prisma
Outdated
| username String @id | ||
| name String | ||
| email String @unique | ||
| model Users { |
There was a problem hiding this comment.
One more thing I missed before. In Prisma, the suggestion is to use singular vs. plural forms for the names:
- User vs. Users
- Subdomain vs. Subdomains
- etc
cychu42
force-pushed
the
initSchema
branch
2 times, most recently
from
6877636 to
16c9130
Compare
|
Thank you! I made some changes according to the feedback. |
prisma/schema.prisma
Outdated
| } | ||
|
|
||
| model Challenge { | ||
| id Int @id @default(autoincrement()) |
There was a problem hiding this comment.
| id Int @id @default(autoincrement()) | |
| id Int @id @default(autoincrement()) | |
| domain String @db.VarChar(255) |
Could you please add this?
prisma/schema.prisma
Outdated
| certificates Certificate? | ||
| } | ||
|
|
||
| model Subdomain { |
There was a problem hiding this comment.
I'm almost certain that this should be called Record because multiple records can have the same subdomain
There was a problem hiding this comment.
Agreed. I think Record is a logical name here, since that's what these are in Route53.
There was a problem hiding this comment.
Make sense. We just need to make sure this is the name we all use outside of user-facing areas, like UI.
Otherwise, it will get confusing.
* Use singular for model names * Arrange enum alphabetically * Make description, course, and ports optional * Add orderURL and domain columns
|
The code is updated according to feedback. |
Closes #16
Closes #59
This is the initial schema for the MySQL database. This includes
Users,Subdomains,Certificates, andChallengesmodels.Let me know if something needs to be changed or added.