Implementing prettier formatting through external file #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal file Co-authored-by: "Ririio" <xririio@gmail.com>
humphd
requested review from
SerpentBytes and
shawnyu5
and removed request for
SerpentBytes
shawnyu5
approved these changes
Feb 2, 2023
Ririio
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Fixes #31
Co-authored-by: "Ririio" xririio@gmail.com
This is a git cleanup of #56 by @Ririio.
This requires you to run
npm installin order to setup the gitpre-commithook, which will run prettier before a commit is added to git. We've also removed theformatscript, since it doesn't seem to work properly due to an issue in prettier's directory scanning logic (we don't really need it, since we have VSCode support and the gitpre-commithook to fix our formatting).