Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Gatsby and Next PR Previews #1447

Closed
humphd opened this issue Nov 23, 2020 · 4 comments · Fixed by #1461
Closed

Build Gatsby and Next PR Previews #1447

humphd opened this issue Nov 23, 2020 · 4 comments · Fixed by #1461
Labels
area: CI/CD Continuous integration / Continuous delivery developer experience Helping the Developer Experience type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Nov 23, 2020

In #1444 I'm going to merge the Gatsby and Next branches together in master so we will have src/frontend/gatsby and src/frontend/next. I'd like to find a way to build both frontends on every PR, while we are porting between the two.

In theory, we can do this with Vercel via their monorepos support. I've tried to understand how this works, but can't, so someone could experiement and do more reading.

Another option would be to do a mix of Netlify and Vercel, one for Gatsby and one for Next.

This is a short term solution, since we'll rip out the Gatsby one once Next is ready.

@humphd humphd added type: enhancement New feature or request area: CI/CD Continuous integration / Continuous delivery developer experience Helping the Developer Experience labels Nov 23, 2020
@humphd
Copy link
Contributor Author

humphd commented Nov 23, 2020

A bunch of sites discuss the difficulty of doing this automatically from git, but that you can do it via GitHub Actions with multiple deploy steps, see https://carlosroso.com/how-to-deploy-a-monorepo-in-vercel/ for example.

@raygervais
Copy link
Contributor

I'd be interested in experimenting with this, continuing my core contributions around the CI/CD & Docker space for 🔭.
Would I need to get Vercel access? I have Netlify access (but not connected to Telescope of course).

Given the amount of build minutes we use in a month, I imagine we'd be close to Netlify's build limit quota. https://www.netlify.com/pricing/faq/

@humphd
Copy link
Contributor Author

humphd commented Nov 25, 2020

@raygervais if you're open to it, that would be great.

I hope that the secondary build will be short lived while we port the frontend, and then we can turn it off. Maybe Netlify would be ok for that period?

@raygervais
Copy link
Contributor

Makes sense, I'll reach out over Slack to discuss Netlify creds or how to access under the Seneca-CDOT account (or walk you through it once I have config done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery developer experience Helping the Developer Experience type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants