Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Port SearchInput to NextJS #1545

Closed
tonyvugithub opened this issue Jan 17, 2021 · 7 comments
Closed

[next] Port SearchInput to NextJS #1545

tonyvugithub opened this issue Jan 17, 2021 · 7 comments
Assignees
Labels
area: nextjs Nextjs related issues type: enhancement New feature or request

Comments

@tonyvugithub
Copy link
Contributor

https://github.com/Seneca-CDOT/telescope/blob/master/src/frontend/gatsby/src/components/SearchInput/SearchInput.jsx
What would you like to be added:
Port SearchInput component to NextJS using TS
Why would you like this to be added:
Porting reason

@tonyvugithub tonyvugithub added type: enhancement New feature or request area: nextjs Nextjs related issues labels Jan 17, 2021
@nilan01
Copy link
Contributor

nilan01 commented Jan 20, 2021

Hi there! Would be happy to take this on once AuthorSearchInput is complete.

@chrispinkney
Copy link
Contributor

@nilan01

Before starting this please see AuthorSearchInput.tsx and PostSearchInput.tsx.

Both search bars are currently styled locally inside the component, however the actual SearchInput component styles both components and passes in a themed style prop that both SearchInput components will need to apply.

See the Gatsby version of SearchInput and AuthorSearchInput.tsx and PostSearchInput.tsx or pm me on slack for more info!

@nilan01
Copy link
Contributor

nilan01 commented Jan 21, 2021

Will do, thanks @chrispinkney !

@PedroFonsecaDEV
Copy link
Contributor

PedroFonsecaDEV commented Jan 21, 2021

We need to clean our Issues because we have dups.
I just send this PR (it was an old and abandoned PR #1520), but the issue number was #1500.

The new PR: #1580

Screen Shot 2021-01-21 at 5 53 22 AM

@PedroFonsecaDEV PedroFonsecaDEV removed this from the 1.5 Release milestone Jan 21, 2021
@chrispinkney
Copy link
Contributor

chrispinkney commented Jan 21, 2021

@PedroFonsecaDEV I don't see anyone assigned to the previous issue (#1500) until you assigned yourself 6 hours ago while Nilan expressed interest in doing this yesterday.

We should double check sometime for any more dupe issues but I don't think there's anymore.

@nilan01
Copy link
Contributor

nilan01 commented Jan 21, 2021

Sorry for the mix-up this was the Searchinput that was linked on the wiki page.

@PedroFonsecaDEV
Copy link
Contributor

PedroFonsecaDEV commented Jan 21, 2021

@PedroFonsecaDEV I don't see anyone assigned to the previous issue (#1500) until you assigned yourself 6 hours ago, while Nilan expressed interest in doing this yesterday.

We should double check sometime for any more dupe issues but I don't think there's anymore.

I was checking for abandoned PRs: PR - 1520
There weren’t any comments about someone working on the PR, and we ship tomorrow. So I jumped in.
I noticed the dup after I sent the PR when I checked the milestone progress, and I saw this issue as part of the milestone.

@chrispinkney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nextjs Nextjs related issues type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants