Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-up flow confirmation page has overflow #3611

Closed
AmasiaNalbandian opened this issue May 17, 2022 · 11 comments · Fixed by #3743
Closed

Sign-up flow confirmation page has overflow #3611

AmasiaNalbandian opened this issue May 17, 2022 · 11 comments · Fixed by #3743
Assignees
Labels
area: css styling Anything related to CSS styling good first issue Good for newcomers hacktoberfest Issue recommended for hacktoberfest type: bug Something isn't working

Comments

@AmasiaNalbandian
Copy link
Contributor

AmasiaNalbandian commented May 17, 2022

What happened:
There is overflow in the confirmation page for the sign-up flow
chrome_Xcc4I4UEmW

What should have happened:
Remove the overflow or handle it.

How to reproduce it (as precise as possible):
Complete sign up link and get to the confirmation page.

@AmasiaNalbandian AmasiaNalbandian added type: bug Something isn't working good first issue Good for newcomers labels May 17, 2022
@cypersii
Copy link

Shall i work on this issue?

@humphd
Copy link
Contributor

humphd commented May 17, 2022

By all means, @cypersii.

@sirinoks sirinoks added the area: css styling Anything related to CSS styling label Jul 25, 2022
@sirinoks
Copy link
Contributor

sirinoks commented Jul 25, 2022

To make this issue hacktoberfest ready, the following needs to be improved:

  • Where is this page/issue located? (link on the website; location in the code)
  • Clean up issue text

@AmasiaNalbandian
Copy link
Contributor Author

To make this issue hacktoberfest ready, the following needs to be improved:

  • Where is this page/issue located? (link on the website; location in the code)
  • Clean up issue text

The file to change can be found here:
https://github.com/Seneca-CDOT/telescope/blob/master/src/web/app/src/components/SignUp/Forms/Review.tsx

@DiegoHdz7
Copy link

Hi, I would like to take this issue for the hacktoberfest, can I take it?

@humphd
Copy link
Contributor

humphd commented Sep 28, 2022

@DiegoHdz7 sure, go for it.

@sirinoks sirinoks added the hacktoberfest Issue recommended for hacktoberfest label Sep 29, 2022
@DiegoHdz7 DiegoHdz7 removed their assignment Oct 10, 2022
@cychu42
Copy link
Contributor

cychu42 commented Oct 24, 2022

Hello, it seems no one is working on this issue. May I take it?

@manekenpix
Copy link
Member

@cychu42 all yours!

@cychu42
Copy link
Contributor

cychu42 commented Oct 25, 2022

I managed to find that the long RSS URL at the bottom is the culprit, so I added word-break: 'break-word' to the CSS for blogRSS class div, which solves the overflow issue presented.

However, I found another issue while testing. I'm not sure how to make the container class div(the one with blue background) auto adjust in case the user wants to add more than 1 of those long RSS. As you can see in the picture below, a second Twitch URL would overlap with the buttons.
review_page

I can just set the height to bigger...but I doubt it’s a good solution.

@humphd
Copy link
Contributor

humphd commented Oct 25, 2022

cc @PedroFonsecaDEV. Maybe we should use trailing ellipses ... to shorten it, and show the whole thing on hover?

@cychu42
Copy link
Contributor

cychu42 commented Oct 27, 2022

My first thought was making a scrollable box, but the ellipses and hover idea would look way better.
I can try to implement the idea and make a PR for further review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: css styling Anything related to CSS styling good first issue Good for newcomers hacktoberfest Issue recommended for hacktoberfest type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants