__get_metadata_key missing return value

[sunday-will]

` def __get_metadata_key(self, driver: Driver):
if self._metadata_key:
return self._metadata_key

    driver_version = self.get_cache_key_driver_version(driver)
    browser_version = driver.get_browser_version_from_os()
    browser_version = browser_version if browser_version else ""
    self._metadata_key = f"{self.get_os_type()}_{driver.get_name()}_{driver_version}" \
                         f"_for_{browser_version}"

`

[david-engelmann]

#604

I believe I had a similar issue last night.

[volodymyrm]

webdriver_manager/webdriver_manager/core/driver_cache.py

Line 108 in de0872f

key = self.__get_metadata_key(driver)

key value setting should be updated with condition for the case when __get_metadata(driver) returns None:
For example like this:
key = self.__get_metadata_key(driver) if self.__get_metadata_key(driver) else self._metadata_key

Otherwise it will be always None on the first run

[SergeyPirogov]

@volodymyrm check the code. There is a check for None

[volodymyrm]

@volodymyrm check the code. There is a check for None

Yes, there is a check if "key" is None, but I mean the case when self.__get_metadata_key(driver) returns None. And actually it will always returns None on the first run, because this condition will always meet
def __get_metadata_key(self, driver: Driver):
if self._metadata_key:
return self._metadata_key

But after returning None, __get_metadata_key defining the key and stores it as self._metadata_key, and I am proposing to use it as I wrote above

[MarcelWilson]

@volodymyrm is correct. I'm seeing the same behavior.

webdriver_manager/webdriver_manager/core/driver_cache.py

Lines 138 to 148 in 29a3c0b

	def __get_metadata_key(self, driver: Driver):
	if self._metadata_key:
	return self._metadata_key
	driver_version = self.get_cache_key_driver_version(driver)
	browser_version = driver.get_browser_version_from_os()
	browser_version = browser_version if browser_version else ""
	self._metadata_key = f"{self.get_os_type()}_{driver.get_name()}_{driver_version}" \
	f"_for_{browser_version}"
	def get_cache_key_driver_version(self, driver: Driver):

---

EDIT: Oh! it appears #582 fixed that in trunk.

webdriver_manager/webdriver_manager/core/driver_cache.py

Lines 138 to 147 in 6b7d03f

	def __get_metadata_key(self, driver: Driver):
	if self._metadata_key:
	return self._metadata_key
	driver_version = self.get_cache_key_driver_version(driver)
	browser_version = driver.get_browser_version_from_os()
	browser_version = browser_version if browser_version else ""
	self._metadata_key = f"{self.get_os_type()}_{driver.get_name()}_{driver_version}" \
	f"_for_{browser_version}"
	return self._metadata_key

It just hasn't been released yet!