Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on bevy default-features #9

Closed
johanhelsing opened this issue Nov 2, 2023 · 1 comment · Fixed by #10
Closed

Don't depend on bevy default-features #9

johanhelsing opened this issue Nov 2, 2023 · 1 comment · Fixed by #10
Labels
bug Something isn't working

Comments

@johanhelsing
Copy link
Contributor

Describe the bug

Depending on bevy means that it's not possible for users of this crate to not pull in bevy_gltf etc. for use in 2D project. This creates unnecessary large builds.

Expected behavior

Have default-features = false for bevy, specify just the needed features.
@johanhelsing johanhelsing added the bug Something isn't working label Nov 2, 2023
@johanhelsing johanhelsing mentioned this issue Nov 2, 2023
Merged
@SergioRibera
Copy link
Owner

Totally agree 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Bevy default-features johanhelsing/virtual_joystick
2 participants
@johanhelsing @SergioRibera