Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake + vcpkg: find_package #211

Closed
vebjornjr opened this issue Apr 8, 2022 · 4 comments
Closed

CMake + vcpkg: find_package #211

vebjornjr opened this issue Apr 8, 2022 · 4 comments
Assignees
@SergiusTheBest
Labels
enhancement
Milestone
1.1.8

Comments

@vebjornjr
Copy link

Hi!

Thank you for this library.

I installed it via vcpkg (manifest mode). CMake's find_package(plog CONFIG REQUIRED) doesn't seem to work for me. I see that this feature has already been discussed (and implemented?) in issue #171. So I'm wondering if my issue is related to the CMake configuration in this project or with the vcpkg port.

Thank you!
@SergiusTheBest
Copy link
Owner

Hi @vebjornjr ,

Is the issue actual? Or did you manage to solve it?

@SergiusTheBest SergiusTheBest self-assigned this Apr 18, 2022
@SergiusTheBest
Copy link
Owner

Indeed find_package doesn't work though the project compiles and can find #include <plog/Log.h>. It seems that vcpkg port needs to be updated to support this feature.

Thank you for reporting!

@SergiusTheBest SergiusTheBest added this to the 1.1.7 milestone Apr 20, 2022
@SergiusTheBest SergiusTheBest modified the milestones: 1.1.7, 1.1.8 Jun 10, 2022
@SergiusTheBest
Copy link
Owner

Sent PR to vcpkg: microsoft/vcpkg#25166.

@SergiusTheBest
Copy link
Owner

The fix is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergiusTheBest SergiusTheBest

Labels
enhancement
Projects
None yet
Milestone
1.1.8
Development

No branches or pull requests
2 participants
@SergiusTheBest @vebjornjr