You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
letmut tagged_file = Probe::open(&opt.path).expect("ERROR: Bad path provided!").read().expect("ERROR: Failed to read file!");let tag = tagged_file.primary_tag_mut().unwrap();
tag.set_track(9);
tag.set_track_total(13);
tag.save_to_path(&opt.path).unwrap()
Summary
Track numbers in id3v2 are stored in the TRCK frame, encoded like this {track_number}/{track_total}. Lofty-rs tag currently writes track and track_total as two separate TRCK frames. It looks like this in a hex editor: TRCK.......9TRCK.......13
Suggested fix:
in src/id3/v2/tag.rs on line 763 in tag_frames add special handling for these frames.
Expected behavior
Lofty writing the TRCK frame correctly. Like this: TRCK.......9/13
Reproducer
I tried this code:
Summary
Track numbers in id3v2 are stored in the TRCK frame, encoded like this
{track_number}/{track_total}
. Lofty-rs tag currently writes track and track_total as two separate TRCK frames. It looks like this in a hex editor:TRCK.......9TRCK.......13
Suggested fix:
in
src/id3/v2/tag.rs
on line 763 in tag_frames add special handling for these frames.Expected behavior
Lofty writing the TRCK frame correctly. Like this:
TRCK.......9/13
Assets
ID3v2 Spec (ID3 website is currently broken):
https://web.archive.org/web/20191202011405/http://id3.org/id3v2.4.0-frames
The text was updated successfully, but these errors were encountered: