Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Picture interface to ApeTag #280

Open
Serial-ATA opened this issue Oct 23, 2023 · 0 comments · May be fixed by #348
Open

Add a Picture interface to ApeTag #280

Serial-ATA opened this issue Oct 23, 2023 · 0 comments · May be fixed by #348
Labels
enhancement New feature or request

Comments

@Serial-ATA
Copy link
Owner

Summary

There is no easy way to interact with Pictures when using ApeTag. They are currently treated as any other item with ItemValue::Binary.

We could very easily split them off from the other items and store them separately, like we do for VorbisComments.

API design

impl ApeTag {
    /// Removes PictureType::Icon and PictureType::OtherIcon like Id3v2Tag and VorbisComments
    fn insert_picture(&mut self, picture: Picture) -> Option<Picture>;
    fn pictures(&self) -> impl Iterator<Item = &Picture>;
    fn remove_picture_type(&mut self, picture_type: PictureType) -> impl Iterator<Item = Picture>;
}
@Serial-ATA Serial-ATA added the enhancement New feature or request label Oct 23, 2023
@Serial-ATA Serial-ATA added this to the 0.18.0 milestone Jan 3, 2024
@Serial-ATA Serial-ATA modified the milestones: 0.18.0, 0.19.0 Jan 12, 2024
@Serial-ATA Serial-ATA linked a pull request Jan 23, 2024 that will close this issue
@Serial-ATA Serial-ATA removed this from the 0.19.0 milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant