Skip to content

Commit 69a1333

Browse files
SapphicFireSapphicFire
authored
Merge branch 'master' into tvijay-instancescan-branch3
2 parents ea5143a + 222d40a commit 69a1333

4 files changed

+137
-4
lines changed

‎README.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,22 @@ Open-Sourced community contributed and owned repository for Instance Scan Defini
1212

1313
## Category: Manageability
1414

15+
### Inactive user check: Approvals
16+
Check any approvals waiting in inactive users queue
17+
18+
### Inactive user check: Catalog task Assigned To
19+
Check any Catalog Tasks Assigned to Inactive user
20+
1521
### Check any assets assigned to inactive user
1622
Check if any asset is assigned to inactive users.
1723

18-
### Inactive User Check : Catalog Item
24+
### Inactive User Check: Catalog Item
1925
We should ensure that inactive users are removed from being assigned as Catalog item owners.
2026

21-
###Avoid gs.log()Statement
27+
### Check problem ticket assigned to inactive user
28+
Make sure that a problem ticket is not assigned to an inactive user.
29+
30+
### Avoid gs.log() Statement
2231
Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:
2332
gs.info() for informative messages.
2433
gs.warn() for warnings that don’t break functionality but may need attention.
@@ -279,7 +288,8 @@ Select the check box to ignore flushing some server-side caches, thus flushing o
279288
Avoid using gs.sleep() in any script because it does not release session and will cause delays, and add logs to the script whenever gs.sleep() has to be used.
280289

281290
## Category: Security
282-
##Check Mandatory fields on incident
291+
292+
### Check Mandatory fields on incident
283293
This check is used to find mandatory fields on incident
284294

285295
### Avoid using setBasicAuth for REST messages
@@ -348,7 +358,7 @@ Scripts in ACLs ARE executed regardless of whether or not the Advanced checked b
348358
### Added a Number Prefix which already exists
349359
Creating new number records does not require uniqueness. Though having duplicate number records causes some ServiceNow core functionality not to behave as expected. For example, the search might return a record from another table the number prefix is also used on.
350360

351-
## List Inactive users from active group
361+
### List Inactive users from active group
352362
List inactive users that still belongs to activate groups
353363

354364
### HTTP connection records not excluded on clones from Prod

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_589b8c9283251210a765fecfeeaad37a.xml

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>manageability</category>
6+
<conditions table="sc_task">assigned_to.active=false^EQ<item endquery="false" field="assigned_to.active" goto="false" newquery="false" operator="=" or="false" value="false"/>
7+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
8+
</conditions>
9+
<description>Check any Catalog Tasks Assigned to Inactive user</description>
10+
<documentation_url/>
11+
<finding_type>scan_finding</finding_type>
12+
<name>Inactive user : Cat task Assignment</name>
13+
<priority>2</priority>
14+
<resolution_details/>
15+
<run_condition/>
16+
<score_max>100</score_max>
17+
<score_min>0</score_min>
18+
<score_scale>1</score_scale>
19+
<script><![CDATA[(function (engine) {
20+
21+
// Add your code here
22+
23+
})(engine);]]></script>
24+
<short_description>Check any Catalog Tasks Assigned to Inactive user</short_description>
25+
<sys_class_name>scan_table_check</sys_class_name>
26+
<sys_created_by>admin</sys_created_by>
27+
<sys_created_on>2024-10-31 14:50:50</sys_created_on>
28+
<sys_id>589b8c9283251210a765fecfeeaad37a</sys_id>
29+
<sys_mod_count>0</sys_mod_count>
30+
<sys_name>Inactive user : Cat task Assignment</sys_name>
31+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
32+
<sys_policy/>
33+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
34+
<sys_update_name>scan_table_check_589b8c9283251210a765fecfeeaad37a</sys_update_name>
35+
<sys_updated_by>admin</sys_updated_by>
36+
<sys_updated_on>2024-10-31 14:50:50</sys_updated_on>
37+
<table>sc_task</table>
38+
<use_manifest>false</use_manifest>
39+
</scan_table_check>
40+
<sys_translated_text action="delete_multiple" query="documentkey=589b8c9283251210a765fecfeeaad37a"/>
41+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7741e65ac3291210766bb3edd40131e6.xml

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>manageability</category>
6+
<conditions table="problem">assigned_to.active=false^EQ<item endquery="false" field="assigned_to.active" goto="false" newquery="false" operator="=" or="false" value="false"/>
7+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
8+
</conditions>
9+
<description>Make sure that a problem ticket is not assigned to an inactive user</description>
10+
<documentation_url/>
11+
<finding_type>scan_finding</finding_type>
12+
<name>Check problem assigned to inactive user</name>
13+
<priority>2</priority>
14+
<resolution_details/>
15+
<run_condition/>
16+
<score_max>100</score_max>
17+
<score_min>0</score_min>
18+
<score_scale>1</score_scale>
19+
<script><![CDATA[(function (engine) {
20+
21+
// Add your code here
22+
23+
})(engine);]]></script>
24+
<short_description>Check problem assigned to inactive user</short_description>
25+
<sys_class_name>scan_table_check</sys_class_name>
26+
<sys_created_by>admin</sys_created_by>
27+
<sys_created_on>2024-11-01 01:46:12</sys_created_on>
28+
<sys_id>7741e65ac3291210766bb3edd40131e6</sys_id>
29+
<sys_mod_count>1</sys_mod_count>
30+
<sys_name>Check problem assigned to inactive user</sys_name>
31+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
32+
<sys_policy/>
33+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
34+
<sys_update_name>scan_table_check_7741e65ac3291210766bb3edd40131e6</sys_update_name>
35+
<sys_updated_by>admin</sys_updated_by>
36+
<sys_updated_on>2024-11-01 01:48:09</sys_updated_on>
37+
<table>problem</table>
38+
<use_manifest>false</use_manifest>
39+
</scan_table_check>
40+
<sys_translated_text action="delete_multiple" query="documentkey=7741e65ac3291210766bb3edd40131e6"/>
41+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_8de1905683e512103d6c98c6feaad3b9.xml

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>manageability</category>
6+
<conditions table="sysapproval_approver">approver.active=false^EQ<item endquery="false" field="approver.active" goto="false" newquery="false" operator="=" or="false" value="false"/>
7+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
8+
</conditions>
9+
<description>Check any approvals waitin on inactive users queue</description>
10+
<documentation_url/>
11+
<finding_type>scan_finding</finding_type>
12+
<name>Inactive user check : Approval</name>
13+
<priority>1</priority>
14+
<resolution_details/>
15+
<run_condition/>
16+
<score_max>100</score_max>
17+
<score_min>0</score_min>
18+
<score_scale>1</score_scale>
19+
<script><![CDATA[(function (engine) {
20+
21+
// Add your code here
22+
23+
})(engine);]]></script>
24+
<short_description>Check any approvals waitin on inactive users queue</short_description>
25+
<sys_class_name>scan_table_check</sys_class_name>
26+
<sys_created_by>admin</sys_created_by>
27+
<sys_created_on>2024-10-31 15:26:29</sys_created_on>
28+
<sys_id>8de1905683e512103d6c98c6feaad3b9</sys_id>
29+
<sys_mod_count>0</sys_mod_count>
30+
<sys_name>Inactive user check : Approval</sys_name>
31+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
32+
<sys_policy/>
33+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
34+
<sys_update_name>scan_table_check_8de1905683e512103d6c98c6feaad3b9</sys_update_name>
35+
<sys_updated_by>admin</sys_updated_by>
36+
<sys_updated_on>2024-10-31 15:26:29</sys_updated_on>
37+
<table>sysapproval_approver</table>
38+
<use_manifest>false</use_manifest>
39+
</scan_table_check>
40+
<sys_translated_text action="delete_multiple" query="documentkey=8de1905683e512103d6c98c6feaad3b9"/>
41+
</record_update>

0 commit comments

Comments
 (0)