Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Minor aesthetic improvements #12

Open
14 of 19 tasks
SethCram opened this issue Jan 29, 2023 · 0 comments
Open
14 of 19 tasks

[ENHANCEMENT] Minor aesthetic improvements #12

SethCram opened this issue Jan 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SethCram
Copy link
Owner

SethCram commented Jan 29, 2023

Is your feature request related to a problem? Please describe.

  • Yes, the aesthetic of the website isn't very good

Describe the solution you'd like

  • Minor aesthetic improvements

Additional context

  • each post on the home page should have a background
    • marks where it ends and a new post begins

Development

  • add bg to each post on homepage

    • reused sidebar bg for dark and light
    • each post can have diff sized outline tho
    • should center contents and have same box size regardless
      • if not enough description, image may not be justified to the top
  • display each post's author on homepage too

  • add site name to topbar

    • in the middle for phones
    • on the LHS for desktops
    • was able to add favicon too
      • used favicon.io and created my own
      • said to add to root of repo, but had to add to public folder for root access
      • likely bc index.html is in public folder too
      • still had to keep 2 copies of favicon tho bc
        • "Module not found: Error: You attempted to import ../../../public/favicon/android-chrome-512x512.png which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
          You can either move it inside src/, or add a symlink to it from project's node_modules/."
  • center single-column posts on the screen

    • centered all posts on screen
    • changed flex from 90% to 100% and justified content to center
      • not sure why it was at 90% before
      • possibly bc user sidebar was always present
  • w/ user not displayed, allow homepage full flex

  • tell user when login fails

    • can look at other pages that do this
    • output error msg from backend
  • fix error 404 link and wording

    • should be worded "Get Help"
    • changed containers so that space around link didnt go anywhere
  • dont display categories section if no cats but follow at icons present

    • changed to check array length instead of non-related icon links
  • use CSS variable for dark mode

    • can change it depending on light or dark mode
    • should be applied to all black text in project
      • so can then turn it white
    • should test with simple implementation before replacing variable names everywhere
      • didn't work properly
    • changed to going down to app.css and implementing default color based on whether dark or light active
  • set max width for user sidebar

    • set to 50% of page width for w/ displayed below other contents in isolation
  • consolidate MultiSelect configuration into a single reusable component

  • emphasize dropdown arrow on write page in darkmode

    • couldn't change its color
    • so added a grey border around it
    • kinda weird looking since arrow not rlly centered
      • so moved it up
      • looks a bit better but not perfect
  • link sidebar username to search posts by username

  • add criteria that was searched by w/ search results shown

    • luckily, already a url parsing method in use
    • restricted it to rerun everytime search url changed and parse for username, category, searchContents, and page number
    • then displayed those fields in the search results header
  • set visibility timeout for all error and success messages

  • clear searchbar suggestions when enter pressed

  • restrict max post title length

    • or atleast max post title length of a single word
    • leads to title row overflow of post container
  • only display what username replying to if not replying to root comment

  • only require favicon in one location instead of 2 duplicates

@SethCram SethCram added the enhancement New feature or request label Jan 29, 2023
@SethCram SethCram self-assigned this Jan 29, 2023
@SethCram SethCram moved this to 🔖 Ready in Book Club Development Board Jan 29, 2023
@SethCram SethCram moved this from 🔖 Ready to Planned in Book Club Development Board Feb 6, 2023
@github-project-automation github-project-automation bot moved this from Planned to ✅ Done in Book Club Development Board Feb 10, 2023
@SethCram SethCram moved this from ✅ Done to 👀 In review in Book Club Development Board Feb 10, 2023
@SethCram SethCram moved this from 👀 In review to Planned in Book Club Development Board Feb 12, 2023
@SethCram SethCram reopened this Feb 12, 2023
@SethCram SethCram moved this from Planned to 🏗 In progress in Book Club Development Board Feb 12, 2023
@SethCram SethCram moved this from 🏗 In progress to 👀 In review in Book Club Development Board Feb 16, 2023
@SethCram SethCram moved this from 👀 In review to 🏗 In progress in Book Club Development Board Feb 24, 2023
@SethCram SethCram moved this from 🏗 In progress to 👀 In review in Book Club Development Board Feb 24, 2023
@SethCram SethCram moved this from 👀 In review to 🏗 In progress in Book Club Development Board Feb 24, 2023
@SethCram SethCram moved this from 🏗 In progress to 👀 In review in Book Club Development Board Feb 24, 2023
@SethCram SethCram added the help wanted Extra attention is needed label Mar 10, 2023
@SethCram SethCram moved this from 👀 In review to 🏗 In progress in Book Club Development Board Mar 17, 2023
@SethCram SethCram moved this from 🏗 In progress to 👀 In review in Book Club Development Board Mar 17, 2023
@SethCram SethCram moved this from 👀 In review to Planned in Book Club Development Board Apr 2, 2023
@SethCram SethCram closed this as completed Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Planned to ✅ Done in Book Club Development Board Apr 3, 2023
@SethCram SethCram moved this from ✅ Done to 👀 In review in Book Club Development Board Apr 3, 2023
@SethCram SethCram moved this from 👀 In review to 🦐 Planned in Book Club Development Board Apr 23, 2023
@SethCram SethCram moved this from 🦐 Planned to 🏗 In progress in Book Club Development Board Apr 24, 2023
@SethCram SethCram reopened this Apr 24, 2023
@SethCram SethCram moved this from 🏗 In progress to 👀 In review in Book Club Development Board Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: 👀 In review
Development

No branches or pull requests

1 participant