Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #17

Open
Het-Shah opened this issue May 19, 2020 · 10 comments
Open

Update README.rst #17

Het-Shah opened this issue May 19, 2020 · 10 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@Het-Shah
Copy link
Member

Currently, the readme has nothing in it. Add installation instructions for the library and also make a checklist of papers we have currently implemented.

@Het-Shah Het-Shah added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 19, 2020
@Het-Shah
Copy link
Member Author

I have made a pypi package for this as well.
Make sure to add it as well.
https://pypi.org/project/KD-Lib/0.0.1/

@Het-Shah
Copy link
Member Author

Het-Shah commented May 21, 2020

I have updated the README.rst as of now. @khizirsiddiqui add the conda package when you get time and then we will close this issue.

@Het-Shah
Copy link
Member Author

Het-Shah commented Jun 1, 2020

@khizirsiddiqui any updates on this?

@khizirsiddiqui
Copy link
Collaborator

I have opened a PR there. Trying to resolve the build errors there.

@Het-Shah
Copy link
Member Author

Het-Shah commented Jun 2, 2020

where exactly, I didn't get you?

@khizirsiddiqui
Copy link
Collaborator

So, what I have understood is: there is a template in conda-forge/staged-recipes. Fork the repo, create a new folder in recipes in the fork for KD_Lib. Send a PR to their repo (I am here). When all tests pass, the PR is merged and called a feedstock. Then everything is handled by conda-forge.

Here is the PR: Link

@Het-Shah
Copy link
Member Author

Het-Shah commented Jun 2, 2020

Oh okay. I don't really know the process. Cool let me know once it is done.

@Het-Shah Het-Shah added this to the v0.1 milestone Aug 28, 2020
@Het-Shah
Copy link
Member Author

Het-Shah commented Sep 9, 2020

Any updates on conda thing? @khizirsiddiqui

@khizirsiddiqui
Copy link
Collaborator

@Het-Shah I couldn't get much time for this, conda is weird, unless this is a priority, I will do it later?

@Het-Shah
Copy link
Member Author

Het-Shah commented Sep 9, 2020

Yea ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants