Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: erasing effect of shadows #30

Open
ShaMan123 opened this issue May 26, 2024 · 1 comment
Open

[BUG]: erasing effect of shadows #30

ShaMan123 opened this issue May 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ShaMan123
Copy link
Owner

ShaMan123 commented May 26, 2024

Shadows were not taken into account when designing the erasing effect unfortunately.
This breaks the entire approach...

A possible solution could be to use context isolation to erase the shadows.
An app could decide that during erasing shadows are not erasable... that is easy to do if the shadow is treated as a non erasable object. But is that desired? Probably not

Screen.Recording.2024-05-26.at.8.51.10.mov
@ShaMan123 ShaMan123 added the bug Something isn't working label May 26, 2024
@ShaMan123
Copy link
Owner Author

ShaMan123 commented Jun 17, 2024

Using a loop renderer with dirty rect optimization could enable refactoring the erasing effect entirely and as a result solve this issue.
The impl could be to render the erasing effect on each object, tracking the pointer while drawing.
In that case it will make sense making the eraser to be a standalone 2d canvas impl and drop the fabric impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant