ohem_ratio

[ChenghaoMou]

In the code comment, ohem_ratio refers to the max ratio of positive/negative, defautls to 0.0, which means no ohem.

But later in the code, it is computing keep_num with a formula keep_num = min(int(pos_num * self.ohem_ratio / logits_size), neg_num).

Should the comment be changed to negative/positive?

[kamfonas]

I had the same question. I am looking at the provided example where ohem=0.1. I think if the intention were for ohem to be negative/positive then the example should probably use ohem = 10 instead. This makes me think that the intention is for ohem to be as specified in the comments: pos/neg, but the formula used should be changed to keep_num = min(int(pos_num / self.ohem_ratio / logits_size), neg_num)