Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helloworld-webpart.spapp to my App Catalog, deploy option greyed out #245

Closed
4 tasks
MLDBlueMetal opened this issue Oct 18, 2016 · 37 comments
Closed
4 tasks

Comments

@MLDBlueMetal
Copy link

When I add my helloworld-webpart.spapp to my app catalog I do not get prompted to deploy the file when I drag and drop it and the ribbon command to deploy is greyed out. I am logged in as tenant administrator and I created both the app catalog and my developer site with the same account. What is the deal?

I have updated to SPx Drop 5 and it did fix the certificate issue using gulp serve. Thank you for that.

Category

  • [X ] Question
  • Typo
  • Bug
  • Enhancement / Suggestion
  • Additional article idea
@patmill
Copy link
Contributor

patmill commented Oct 18, 2016

Did this work in a previous build on the same tenant? Are you using a developer tenant (not site collection, but a developer tenant)?

@MLDBlueMetal
Copy link
Author

I was on a business tenant not developer tenant. There are so many steps to get this working that I must have missed that important piece of information.

I have now added/deployed the file successfully to App Store on my o365 Developer Tenant.
apps

However when I add the app to a site, I see these error messages now when I try to add the web part to a page. What did I miss now?

This shouldn't be so hard :-(
error2

error

@patmill
Copy link
Contributor

patmill commented Oct 18, 2016

Fair point, and we plan on smoothing out the bumps.

To get around the issue you are currently seeing, create a publishing site collection (or a developer site collection). These site collections don't have NoScript enabled (technically, they don't have the Add Customize Page permission removed). There is a whole discussion to be had around NoScript and how the framework interacts with it (again - we have work items to make it work nicer with NoScript sites).

@MLDBlueMetal
Copy link
Author

Well, getting closer. Any help with this one now?

hellomld

@patmill
Copy link
Contributor

patmill commented Oct 18, 2016

If you are following the labs, are you on this lab (http://dev.office.com/sharepoint/docs/spfx/web-parts/get-started/serve-your-web-part-in-a-sharepoint-page) or this one (http://dev.office.com/sharepoint/docs/spfx/web-parts/get-started/deploy-web-part-to-cdn)?

If you haven't deployed to a CDN, is gulp serve running?

@MLDBlueMetal
Copy link
Author

Thank you for the links. I see all of the dependency files are not bundled into the .spapp packaged file. I will try running gulp with no browser. I am not sure if this is just me but is the app packaging going to be simplified when moving from DEV (localhost) to a production server? Could we have one file in config for all dependencies set by a variable instead of URLS? in the example it would be awesome if we coykd change the host and CDN locations in one place to facilitate deoyment from DEV to staging and then eventuallu production? All dependent files should point to the variable rather than a static URL. Does that make sense? Am I asking for too much? :-)

@MLDBlueMetal
Copy link
Author

I apologize for all typos! On my phone

@patmill
Copy link
Contributor

patmill commented Oct 18, 2016

Just to make sure - is your original set of issues sorted out (your webpart is now working)? Your other feedback is received and appreciated.

@MLDBlueMetal
Copy link
Author

Yes this is now resolved. I ran gulp serve --nobrowser after adding the app to my developer tenant and I was able to see the web part working in my dev site! Thank you!!

@Rajesh-Pradhan
Copy link

Guys I'm still not able to see the Deployment window while adding .spapp file to App Catalog. It simply added with no pop up window

@GrahamMcMynn
Copy link

Is the app package valid (ie under Valid App Package you see "Yes")?

@chakkaradeep
Copy link
Contributor

@Rajesh-Pradhan Can you also confirm if you are on a Office 365 Developer Tenant?

@Rajesh-Pradhan
Copy link

@chakkaradeep Yes I'm on Office 365 Developer Tenant

@Rajesh-Pradhan
Copy link

@chak
capture1
karadeep @mcmynn83 Here is the screen i'm getting after uploading to App catalog

@patmill
Copy link
Contributor

patmill commented Nov 11, 2016

Hi @Rajesh-Pradhan - would you mind showing your tenant URL? Alternately, you can email it to me at my username @microsoft.com . We need to make sure that you are on a developer tenancy, not a developer site collection.
Another avenue is to go to the app catalog list itself and modify the view. There is a new column that should show was the error for the invalid package is. What does it say?

@Rajesh-Pradhan
Copy link

Hi @patmill I have modify the view and i found "App Package Error Message" column but over there no information is found. Also due to policies I'm not bale to share my URL , but my URL looks like "https://xxxxxxxx.sharepoint.com/sites/apps/AppCatalog/Forms/AllItems.aspx" .

@BenGWeeks
Copy link

BenGWeeks commented Feb 1, 2017

Did you guys resolve this? I am seeing the same thing. I had a create a new App Catalog (presume this does not need to be a developer site collection, I don't recall seeing an option for that, but the site collection I want to add the SPFx web part to is indeed a developer tenancy). Likewise, I got no pop-up saying to trust, "Valid App Package" is set to "No" and "App Package Error" is blank. I second @MLDBlueMetal that it would be nice if by default all assets required as also packaged into the web part that is deployed rather than needing to setup CDN's.

@mauricionr
Copy link

@GrahamMcMynn
Copy link

@webtechy - you are not getting a pop-up saying to trust the app because it is not a valid app package. One of two things is happening:

  1. The feature is not enabled on your tenant - Do you have first release set for your entire tenant?
  2. The app package is invalid... in which case you should have an App Package Error. Most likely the problem is Add link to Wiki #1.

Please validate that First Release is set for your entire tenant... also if possible please send the URL of your site collection your are having issues with.

Thanks,
Graham

@paigeflourin
Copy link

Hello,

@mcmynn83 i am also encountering this error with my package, i followed this one step by step https://dev.office.com/sharepoint/docs/spfx/web-parts/get-started/serve-your-web-part-in-a-sharepoint-page it works locally but when i try to deploy it to my app catalog, i get no error but the "valid app package" is set to no,

capture

i checked the tenant and First release is enabled and my account is part of it.

capture

@BenGWeeks
Copy link

Hi @paigeflourin, try adding the App Package Error to the columns in that view. Someone may correct me, but I don't think it works with only specific people, you need first release for the whole site collection.

@paigeflourin
Copy link

@webtechy Hi Ben,
i added the field unfortunately there is no error.

capture

@BenGWeeks
Copy link

Have you tried switching First Release on for everyone? In my experience this was needed, and I had to leave it for a bit and go and have a coffee before it started working.

@GrahamMcMynn
Copy link

@paigeflourin - webtechy is correct, first release MUST be set for the entire org if you want to have app packages validate and be usable before GA. The behavior you are seeing is expected.

@GrahamMcMynn
Copy link

@webtechy - Sounds like your issue has been resolved then? You are correct, First Release settings take a while to propagate. Unfortunately there is no way to check that the setting has propagated.

@BenGWeeks
Copy link

(Would be nice to have an error message that told you that though ;-))

@GrahamMcMynn
Copy link

I understand this causes grief... the good thing is it is only temporary. Once the product is rolled out world wide for GA nobody will see this problem. First Release basically turns on a feature that just straight up does not exist without it. Therefore the reason you don't get a nice error message is the code has no idea that it is a possibly valid client side package, it just sees it as completely invalid 2013 app package. Sorry about that.

@paigeflourin
Copy link

HEllo @webtechy @mcmynn83 yeah first release for everyone made it work. thanks guys!

@GrahamMcMynn
Copy link

Excellent glad you were able to resolve the issue!

@Savan12791
Copy link

image

I have created a RSSFeed Webpart from Scratch its working fine on local workbranch but when i deployed its sppkg file to appcatalog and added it to webpart page its giving me the following error.
How to reslove it?

@BenGWeeks
Copy link

BenGWeeks commented Mar 17, 2017

Couple of points:

  1. Run gulp clean before running gulp build --ship, gulp bundle --ship and gulp package-solution --ship

  2. Ensure you have set the CDN location correctly in the write-manifest.json,e.g.

{
  "cdnBasePath": "https://somesite.sharepoint.com/sites/Development/SiteAssets/somefolder/"
}
  1. Ensure you are deploying the temp/deploy and NOT the dist folder to the CDN location (check the F12 network tab where it is looking for the assets). (CORRECTED)

@Savan12791
Copy link

But i its also required the temp\deploy files.

@amarnathpoosala
Copy link

Hi I am also facing the same issue. I am not able to drag and drop the .sppkg file in my app catalaog site collection onpremise trial version of sharepoint 2016. Even if I upload the file, I get the Valid App package value NO. Is there something I have to configure to be able to use sppkg files on Onpremise. Is that because trial version doesnt support this? or Only Online version supports spfx? Thanks in advance.

@GrahamMcMynn
Copy link

@amarnathpoosala - SPFX is not currently supported in the on premises version of SharePoint.

@Rajesh-Pradhan
Copy link

Is SPFx now supporting SharePoint 2016 on Premise ?

@andrewconnell
Copy link
Collaborator

@msft-github-bot
Copy link
Collaborator

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@SharePoint SharePoint locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests