Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit first paragraph to remove ACS reference #6812

Closed
ghost opened this issue Mar 12, 2021 · 5 comments
Closed

Edit first paragraph to remove ACS reference #6812

ghost opened this issue Mar 12, 2021 · 5 comments
Labels
area:auth Category: Authentication (Azure AD / etc) area:docs-comment Category: Comment left on bottom of a docs page here: https://docs.microsoft.com/sharepoint/dev status:answered Answer to a question. type:question Question... if answered, will be tagged as such.

Comments

@ghost
Copy link

ghost commented Mar 12, 2021

The first paragraph ends as:

 The authorization server in this scenario is Microsoft Azure Access Control Service (ACS).

Then there is a huge blue box under that, talking about retirement of ACS in 2018 (more than 2 years ago).

Please edit the first paragraph and other references to the (now retired ?) ACS and provide updated information.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ghost
Copy link

ghost commented Mar 12, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added Needs: Triage 🔍 Awaiting categorization and initial review. area:docs-comment Category: Comment left on bottom of a docs page here: https://docs.microsoft.com/sharepoint/dev labels Mar 12, 2021
@andrewconnell
Copy link
Collaborator

Continue reading the blue box... it states that even though retired, it doesn't impact add-ins.

@andrewconnell andrewconnell added area:auth Category: Authentication (Azure AD / etc) status:answered Answer to a question. type:question Question... if answered, will be tagged as such. and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Mar 16, 2021
@ghost
Copy link
Author

ghost commented Mar 17, 2021

I read that, and that confused me more. Hence this ticket. Does that clause in the parans mean:

  1. SharePoint Add-ins never used them, now that ACS is retired you are not impacted
  2. Though it is retired, SharePoint Addins still need to use ACS

#1 is clearly not the case because the entire article is about using it with SPS Addins. Which leaves #2, which asks that developers use the ACS (retired now!) service to perform AuthZ. Is it one day going to stop working for this scenario too? Is there some alternate service/API people should switch over to?

When you read it as an existing SPS Add-in developer (i.e., one who has a few addins in play) with no plans to change or upgrade their code, you would read "okay, no impact to me" and move on. But if you're someone writing a new set of add-ins or working on upgrade plans/etc, then this creates more questions.

The text is not clear to me.

@andrewconnell
Copy link
Collaborator

I think you're reading into this a bit more than necessary :). This doc simply explains show things work under the covers. Originally, add-ins use ACS... but since then Azure retired ACS, but not the underlying infrastructure that implemented it.

As such, there's no impact to SharePoint add-ins... everything in the doc still applies... the extra callout about ACS being retired was simply added to address all the questions MSFT was receiving about "now that ACS is being retired, how will this impact add-ins".

The blue box is saying "it doesn't".

@ghost
Copy link

ghost commented Mar 30, 2021

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:auth Category: Authentication (Azure AD / etc) area:docs-comment Category: Comment left on bottom of a docs page here: https://docs.microsoft.com/sharepoint/dev status:answered Answer to a question. type:question Question... if answered, will be tagged as such.
Projects
None yet
Development

No branches or pull requests

1 participant