Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default SPFx v1.13.1 project recommends unnecessary & deprecated VSCode extension #7558

Closed
1 of 9 tasks
andrewconnell opened this issue Dec 2, 2021 · 3 comments
Closed
1 of 9 tasks
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Milestone

Comments

@andrewconnell
Copy link
Collaborator

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

macOS

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • SPFx v1.13.1
  • Node.js v14

Describe the bug / error

The default project created by the SPFx v1.13.1 (and most older versions) generator includes a recommendation, via the ./.vscode/extensions.json, to install the Debugger for Chrome:

{
  "recommendations": [
    "msjsdiag.debugger-for-chrome"
  ]
}

If the extension isn't installed, VS Code prompts you to install it:

image

But this extension is now deprecated and it's not recommended by Microsoft to install it, as specified in the extension's README & page on the VSCode Marketplace:

This extension has been deprecated as Visual Studio Code now has a bundled JavaScript Debugger that covers the same functionality. It is a debugger that debugs Node.js, Chrome, Edge, WebView2, VS Code extensions, and more. You can safely un-install this extension and you will still be able to have the functionality you need.

While this isn't a blocker or a bug, would be nice to get this extension suggestion removed from future generator releases.

Steps to reproduce

  1. ensure sure the extension isn't installed in VSCode
  2. VSCode isn't running
  3. create new SPFx project (pick anything for all questions)
  4. open project in VSCode
  5. observe above notification

Expected behavior

New projects don't recommend installing deprecated/unnecessary extensions.

@andrewconnell andrewconnell added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Dec 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 Awaiting categorization and initial review. label Dec 2, 2021
@VesaJuvonen VesaJuvonen added area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Dec 2, 2021
@AJIXuMuK AJIXuMuK added the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Dec 3, 2021
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue planned to be fixed in an upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Dec 14, 2021
@patmill patmill added this to the 1.14 milestone Jan 12, 2022
@AJIXuMuK
Copy link
Collaborator

1.14.0-beta.5 that contains the fix is out.

@ghost
Copy link

ghost commented Feb 4, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

4 participants