Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Readme thelimitation that Controllers that inherit from APIController wont have validation trigger automatically #39

Closed
francis04j opened this issue Dec 4, 2024 · 1 comment · Fixed by #40
Labels
enhancement New feature or request
Milestone

Comments

@francis04j
Copy link

Validators are not triggered automatically for NET Projects that make use of ApiController attribute and conventions as described here.

This mean that if your controller does not inherit ControllerBase or other controller based classes that are provided out of the box, validators won't get triggered automatically

Issue here: #35 (comment)

Code culprit here: https://github.com/SharpGrip/FluentValidation.AutoValidation/blob/master/FluentValidation.AutoValidation.Mvc/src/Filters/FluentValidationAutoValidationActionFilter.cs

@mvdgun
Copy link
Member

mvdgun commented Dec 4, 2024

Hi @francis04j, could you check out #40? I think that solves your problem.

@mvdgun mvdgun added this to the v1.5 milestone Dec 4, 2024
@mvdgun mvdgun added the enhancement New feature or request label Dec 4, 2024
@mvdgun mvdgun linked a pull request Dec 4, 2024 that will close this issue
@mvdgun mvdgun closed this as completed in #40 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants