Skip to content

Commit cbd26f1

Browse files
calixtuscalixtus
authored
Small improvements in preferences dialog (JabRef#6130)
* Changed special buttons to icon buttons * Changed ComboBox lists to use proper display name and added spinner to font size * Fixed KeyPress event * Reworded biblatex to BibLaTeX * l10n * Removed obsolete special pdf treatment in preferences * CHANGELOG.md and removed forgotten bindings * Fixed wrong biblatex fix * checkstyle
1 parent 10f5468 commit cbd26f1

26 files changed

+114
-180
lines changed

‎CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
1515

1616
- We improved the arXiv fetcher. Now it should find entries even more reliably and does no longer include the version (e.g `v1`) in the `eprint` field. [forum#1941](https://discourse.jabref.org/t/remove-version-in-arxiv-import/1941)
1717
- We moved the group search bar and the button "New group" from bottom to top position to make it more prominent. [#6112](https://github.com/JabRef/jabref/pull/6112)
18-
18+
- We changed the buttons for import/export/show all/reset of preferences to smaller icon buttons in the preferences dialog. [#6130](https://github.com/JabRef/jabref/pull/6130)
1919

2020
### Fixed
2121

2222
- We fixed an issue where opening a library from the recent libraries menu was not possible. [#5939](https://github.com/JabRef/jabref/issues/5939)
2323
- We fixed an issue with inconsistent capitalization of file extensions when downloading files [#6115](https://github.com/JabRef/jabref/issues/6115)
24+
- We fixed the display of language and encoding in the preferences dialog. [#6130](https://github.com/JabRef/jabref/pull/6130)
2425

2526
### Removed
2627

28+
- We removed the obsolete `External programs / Open PDF` section in the preferences, as the default application to open PDFs is now set in the `Manage external file types` dialog. [#6130](https://github.com/JabRef/jabref/pull/6130)
29+
2730
## [5.0] – 2020-03-06
2831

2932
### Changed

‎src/main/java/org/jabref/gui/desktop/os/DefaultDesktop.java

-6
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.io.File;
55
import java.io.IOException;
66
import java.nio.file.Path;
7-
import java.util.List;
87

98
import org.slf4j.Logger;
109
import org.slf4j.LoggerFactory;
@@ -33,11 +32,6 @@ public void openConsole(String absolutePath) throws IOException {
3332
LOGGER.error("This feature is not supported by your Operating System.");
3433
}
3534

36-
@Override
37-
public void openPdfWithParameters(String filePath, List<String> parameters) throws IOException {
38-
//TODO imlement default
39-
}
40-
4135
@Override
4236
public String detectProgramPath(String programName, String directoryName) {
4337
return programName;

‎src/main/java/org/jabref/gui/desktop/os/Linux.java

-23
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,17 @@
66
import java.io.InputStreamReader;
77
import java.nio.file.Path;
88
import java.nio.file.Paths;
9-
import java.util.List;
109
import java.util.Locale;
1110
import java.util.Optional;
12-
import java.util.StringJoiner;
1311

1412
import org.jabref.JabRefExecutorService;
1513
import org.jabref.gui.externalfiletype.ExternalFileType;
1614
import org.jabref.gui.externalfiletype.ExternalFileTypes;
1715
import org.jabref.gui.util.StreamGobbler;
18-
import org.jabref.preferences.JabRefPreferences;
1916

2017
import org.slf4j.Logger;
2118
import org.slf4j.LoggerFactory;
2219

23-
import static org.jabref.preferences.JabRefPreferences.ADOBE_ACROBAT_COMMAND;
24-
import static org.jabref.preferences.JabRefPreferences.USE_PDF_READER;
25-
2620
public class Linux implements NativeDesktop {
2721

2822
private static final Logger LOGGER = LoggerFactory.getLogger(Linux.class);
@@ -108,23 +102,6 @@ public void openConsole(String absolutePath) throws IOException {
108102
}
109103
}
110104

111-
@Override
112-
public void openPdfWithParameters(String filePath, List<String> parameters) throws IOException {
113-
114-
String application;
115-
if (JabRefPreferences.getInstance().get(USE_PDF_READER).equals(JabRefPreferences.getInstance().get(ADOBE_ACROBAT_COMMAND))) {
116-
application = "acroread";
117-
118-
StringJoiner sj = new StringJoiner(" ");
119-
sj.add(application);
120-
parameters.forEach((param) -> sj.add(param));
121-
122-
openFileWithApplication(filePath, sj.toString());
123-
} else {
124-
openFile(filePath, "PDF");
125-
}
126-
}
127-
128105
@Override
129106
public String detectProgramPath(String programName, String directoryName) {
130107
return programName;

‎src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java

-9
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.io.IOException;
44
import java.nio.file.Path;
55
import java.nio.file.Paths;
6-
import java.util.List;
76

87
public interface NativeDesktop {
98
void openFile(String filePath, String fileType) throws IOException;
@@ -21,14 +20,6 @@ public interface NativeDesktop {
2120

2221
void openConsole(String absolutePath) throws IOException;
2322

24-
/**
25-
* This method opens a pdf using the giving the parameters to the executing pdf reader
26-
* @param filePath absolute path to the pdf file to be opened
27-
* @param parameters console parameters depending on the pdf reader
28-
* @throws IOException
29-
*/
30-
void openPdfWithParameters(String filePath, List<String> parameters) throws IOException;
31-
3223
String detectProgramPath(String programName, String directoryName);
3324

3425
/**

‎src/main/java/org/jabref/gui/desktop/os/OSX.java

-6
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.io.IOException;
66
import java.nio.file.Path;
77
import java.nio.file.Paths;
8-
import java.util.List;
98
import java.util.Optional;
109

1110
import org.jabref.gui.externalfiletype.ExternalFileType;
@@ -42,11 +41,6 @@ public void openConsole(String absolutePath) throws IOException {
4241
Runtime.getRuntime().exec("open -a Terminal " + absolutePath, null, new File(absolutePath));
4342
}
4443

45-
@Override
46-
public void openPdfWithParameters(String filePath, List<String> parameters) throws IOException {
47-
//TODO implement
48-
}
49-
5044
@Override
5145
public String detectProgramPath(String programName, String directoryName) {
5246
return programName;

‎src/main/java/org/jabref/gui/desktop/os/Windows.java

-22
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,10 @@
44
import java.io.IOException;
55
import java.nio.file.Path;
66
import java.nio.file.Paths;
7-
import java.util.List;
87
import java.util.Optional;
98

109
import org.jabref.gui.externalfiletype.ExternalFileType;
1110
import org.jabref.gui.externalfiletype.ExternalFileTypes;
12-
import org.jabref.preferences.JabRefPreferences;
13-
14-
import static org.jabref.preferences.JabRefPreferences.ADOBE_ACROBAT_COMMAND;
15-
import static org.jabref.preferences.JabRefPreferences.SUMATRA_PDF_COMMAND;
16-
import static org.jabref.preferences.JabRefPreferences.USE_PDF_READER;
1711

1812
public class Windows implements NativeDesktop {
1913
private static String DEFAULT_EXECUTABLE_EXTENSION = ".exe";
@@ -69,20 +63,4 @@ public void openConsole(String absolutePath) throws IOException {
6963
process.directory(new File(absolutePath));
7064
process.start();
7165
}
72-
73-
@Override
74-
public void openPdfWithParameters(String filePath, List<String> parameters) throws IOException {
75-
String pdfReaderPath = JabRefPreferences.getInstance().get(USE_PDF_READER);
76-
if (pdfReaderPath.equals(SUMATRA_PDF_COMMAND) || pdfReaderPath.equals(ADOBE_ACROBAT_COMMAND)) {
77-
String[] command = new String[parameters.size() + 2];
78-
command[0] = "\"" + Paths.get(pdfReaderPath).toString() + "\"";
79-
for (int i = 1; i < command.length - 1; i++) {
80-
command[i] = "\"" + parameters.get(i - 1) + "\"";
81-
}
82-
command[command.length - 1] = "\"" + filePath + "\"";
83-
new ProcessBuilder(command).start();
84-
} else {
85-
openFile(filePath, "PDF");
86-
}
87-
}
8866
}

‎src/main/java/org/jabref/gui/exporter/SaveAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*/
1212
public class SaveAction extends SimpleCommand {
1313

14-
public enum SaveMethod {SAVE, SAVE_AS, SAVE_SELECTED}
14+
public enum SaveMethod { SAVE, SAVE_AS, SAVE_SELECTED }
1515

1616
private final SaveMethod saveMethod;
1717
private final JabRefFrame frame;

‎src/main/java/org/jabref/gui/icon/IconTheme.java

+1
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ public enum JabRefIcons implements JabRefIcon {
228228
GITHUB(MaterialDesignIcon.GITHUB_CIRCLE), /*css: github-circle*/
229229
TOGGLE_ENTRY_PREVIEW(MaterialDesignIcon.LIBRARY_BOOKS), /*css: library-books */
230230
TOGGLE_GROUPS(MaterialDesignIcon.VIEW_LIST), /*css: view-list */
231+
SHOW_PREFERENCES_LIST(MaterialDesignIcon.VIEW_LIST), /*css: view-list */
231232
WRITE_XMP(MaterialDesignIcon.IMPORT), /* css: import */
232233
FILE_WORD(MaterialDesignIcon.FILE_WORD), /*css: file-word */
233234
FILE_EXCEL(MaterialDesignIcon.FILE_EXCEL), /*css: file-excel */

‎src/main/java/org/jabref/gui/preferences/AppearanceTab.fxml

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<?import javafx.scene.layout.VBox?>
88

99
<?import javafx.scene.layout.HBox?>
10-
<?import javafx.scene.control.TextField?>
1110
<?import javafx.geometry.Insets?>
11+
<?import javafx.scene.control.Spinner?>
1212
<fx:root prefWidth="650.0" spacing="10.0" type="VBox" xmlns="http://javafx.com/javafx/11.0.1"
1313
xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.jabref.gui.preferences.AppearanceTabView">
1414
<fx:define>
@@ -18,9 +18,9 @@
1818

1919
<Label styleClass="sectionHeader" text="%Font"/>
2020
<CheckBox fx:id="fontOverride" text="%Override default font settings"/>
21-
<HBox spacing="4.0" alignment="CENTER_LEFT">
22-
<Label text="%Size:" disable="${!fontOverride.selected}"/>
23-
<TextField fx:id="fontSize" prefWidth="40" alignment="CENTER_RIGHT" disable="${!fontOverride.selected}"/>
21+
<HBox alignment="CENTER_LEFT" spacing="4.0">
22+
<Label text="%Size" disable="${!fontOverride.selected}"/>
23+
<Spinner fx:id="fontSize" prefWidth="60.0" editable="true"/>
2424
<padding>
2525
<Insets left="20.0"/>
2626
</padding>

‎src/main/java/org/jabref/gui/preferences/AppearanceTabView.java

+9-5
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
import javafx.application.Platform;
44
import javafx.fxml.FXML;
5+
import javafx.geometry.Pos;
56
import javafx.scene.control.CheckBox;
67
import javafx.scene.control.RadioButton;
7-
import javafx.scene.control.TextField;
8+
import javafx.scene.control.Spinner;
89

9-
import org.jabref.gui.util.ControlHelper;
1010
import org.jabref.gui.util.IconValidationDecorator;
1111
import org.jabref.logic.l10n.Localization;
1212
import org.jabref.preferences.JabRefPreferences;
@@ -17,7 +17,7 @@
1717
public class AppearanceTabView extends AbstractPreferenceTabView<AppearanceTabViewModel> implements PreferencesTab {
1818

1919
@FXML public CheckBox fontOverride;
20-
@FXML public TextField fontSize;
20+
@FXML public Spinner<Integer> fontSize;
2121
@FXML public RadioButton themeLight;
2222
@FXML public RadioButton themeDark;
2323

@@ -38,8 +38,12 @@ public void initialize () {
3838
this.viewModel = new AppearanceTabViewModel(dialogService, preferences);
3939

4040
fontOverride.selectedProperty().bindBidirectional(viewModel.fontOverrideProperty());
41-
fontSize.setTextFormatter(ControlHelper.getIntegerTextFormatter());
42-
fontSize.textProperty().bindBidirectional(viewModel.fontSizeProperty());
41+
42+
// Spinner does neither support alignment nor disableProperty in FXML
43+
fontSize.disableProperty().bind(fontOverride.selectedProperty().not());
44+
fontSize.getEditor().setAlignment(Pos.CENTER_RIGHT);
45+
fontSize.setValueFactory(AppearanceTabViewModel.fontSizeValueFactory);
46+
fontSize.getEditor().textProperty().bindBidirectional(viewModel.fontSizeProperty());
4347

4448
themeLight.selectedProperty().bindBidirectional(viewModel.themeLightProperty());
4549
themeDark.selectedProperty().bindBidirectional(viewModel.themeDarkProperty());

‎src/main/java/org/jabref/gui/preferences/AppearanceTabViewModel.java

+4
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import javafx.beans.property.SimpleBooleanProperty;
88
import javafx.beans.property.SimpleStringProperty;
99
import javafx.beans.property.StringProperty;
10+
import javafx.scene.control.SpinnerValueFactory;
1011

1112
import org.jabref.gui.DialogService;
1213
import org.jabref.gui.util.ThemeLoader;
@@ -20,6 +21,9 @@
2021

2122
public class AppearanceTabViewModel implements PreferenceTabViewModel {
2223

24+
public static SpinnerValueFactory<Integer> fontSizeValueFactory =
25+
new SpinnerValueFactory.IntegerSpinnerValueFactory(9, Integer.MAX_VALUE);
26+
2327
private final BooleanProperty fontOverrideProperty = new SimpleBooleanProperty();
2428
private final StringProperty fontSizeProperty = new SimpleStringProperty();
2529
private final BooleanProperty themeLightProperty = new SimpleBooleanProperty();

‎src/main/java/org/jabref/gui/preferences/ExternalTab.fxml

-21
Original file line numberDiff line numberDiff line change
@@ -79,27 +79,6 @@
7979
GridPane.columnIndex="2" GridPane.rowIndex="1"/>
8080
</GridPane>
8181

82-
<Label styleClass="sectionHeader" text="%Open PDF"/>
83-
<GridPane alignment="CENTER_LEFT" hgap="10.0" vgap="4.0">
84-
<columnConstraints>
85-
<ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="200.0"/>
86-
<ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="350.0"/>
87-
<ColumnConstraints hgrow="SOMETIMES"/>
88-
</columnConstraints>
89-
<rowConstraints>
90-
<RowConstraints minHeight="30.0" vgrow="SOMETIMES"/>
91-
<RowConstraints minHeight="30.0" vgrow="SOMETIMES"/>
92-
</rowConstraints>
93-
<RadioButton fx:id="usePDFAcrobat" text="%Adobe Acrobat Reader" toggleGroup="$openPDF"/>
94-
<TextField fx:id="usePDFAcrobatCommand" prefWidth="350.0" GridPane.columnIndex="1"/>
95-
<Button fx:id="usePDFAcrobatBrowse" onAction="#usePDFAcrobatCommandBrowse" text="%Browse"
96-
GridPane.columnIndex="2"/>
97-
<RadioButton fx:id="usePDFSumatra" text="%Sumatra Reader" toggleGroup="$openPDF" GridPane.rowIndex="1"/>
98-
<TextField fx:id="usePDFSumatraCommand" prefWidth="350.0" GridPane.columnIndex="1" GridPane.rowIndex="1"/>
99-
<Button fx:id="usePDFSumatraBrowse" onAction="#usePDFSumatraCommandBrowse" text="%Browse"
100-
GridPane.columnIndex="2" GridPane.rowIndex="1"/>
101-
</GridPane>
102-
10382
<Label styleClass="sectionHeader" text="%Open File Browser"/>
10483
<GridPane alignment="CENTER_LEFT" hgap="10.0" vgap="4.0">
10584
<columnConstraints>

‎src/main/java/org/jabref/gui/preferences/ExternalTabView.java

-17
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,6 @@ public class ExternalTabView extends AbstractPreferenceTabView<ExternalTabViewMo
2828
@FXML private TextField useTerminalCommand;
2929
@FXML private Button useTerminalBrowse;
3030

31-
@FXML private RadioButton usePDFAcrobat;
32-
@FXML private TextField usePDFAcrobatCommand;
33-
@FXML private Button usePDFAcrobatBrowse;
34-
@FXML private RadioButton usePDFSumatra;
35-
@FXML private TextField usePDFSumatraCommand;
36-
@FXML private Button usePDFSumatraBrowse;
37-
3831
@FXML private RadioButton useFileBrowserDefault;
3932
@FXML private RadioButton useFileBrowserSpecial;
4033
@FXML private TextField useFileBrowserSpecialCommand;
@@ -75,16 +68,6 @@ public void initialize() {
7568
useTerminalCommand.disableProperty().bind(useTerminalSpecial.selectedProperty().not());
7669
useTerminalBrowse.disableProperty().bind(useTerminalSpecial.selectedProperty().not());
7770

78-
usePDFAcrobat.selectedProperty().bindBidirectional(viewModel.usePDFAcrobatProperty());
79-
usePDFAcrobatCommand.textProperty().bindBidirectional(viewModel.usePDFAcrobatCommandProperty());
80-
usePDFAcrobatCommand.disableProperty().bind(usePDFAcrobat.selectedProperty().not());
81-
usePDFAcrobatBrowse.disableProperty().bind(usePDFAcrobat.selectedProperty().not());
82-
83-
usePDFSumatra.selectedProperty().bindBidirectional(viewModel.usePDFSumatraProperty());
84-
usePDFSumatraCommand.textProperty().bindBidirectional(viewModel.usePDFSumatraCommandProperty());
85-
usePDFSumatraCommand.disableProperty().bind(usePDFSumatra.selectedProperty().not());
86-
usePDFSumatraBrowse.disableProperty().bind(usePDFSumatra.selectedProperty().not());
87-
8871
useFileBrowserDefault.selectedProperty().bindBidirectional(viewModel.useFileBrowserDefaultProperty());
8972
useFileBrowserSpecial.selectedProperty().bindBidirectional(viewModel.useFileBrowserSpecialProperty());
9073
useFileBrowserSpecialCommand.textProperty().bindBidirectional(viewModel.useFileBrowserSpecialCommandProperty());

‎src/main/java/org/jabref/gui/preferences/ExternalTabViewModel.java

-22
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.jabref.gui.push.PushToApplicationsManager;
2424
import org.jabref.gui.util.FileDialogConfiguration;
2525
import org.jabref.logic.l10n.Localization;
26-
import org.jabref.logic.util.OS;
2726
import org.jabref.model.strings.StringUtil;
2827
import org.jabref.preferences.JabRefPreferences;
2928

@@ -74,17 +73,6 @@ public void setValues() {
7473
useTerminalCommandProperty.setValue(preferences.get(JabRefPreferences.CONSOLE_COMMAND));
7574
useTerminalSpecialProperty.setValue(!preferences.getBoolean(JabRefPreferences.USE_DEFAULT_CONSOLE_APPLICATION));
7675

77-
usePDFAcrobatCommandProperty.setValue(preferences.get(JabRefPreferences.ADOBE_ACROBAT_COMMAND));
78-
if (OS.WINDOWS) {
79-
usePDFSumatraCommandProperty.setValue(preferences.get(JabRefPreferences.SUMATRA_PDF_COMMAND));
80-
81-
if (preferences.get(JabRefPreferences.USE_PDF_READER).equals(usePDFAcrobatCommandProperty.getValue())) {
82-
usePDFAcrobatProperty.setValue(true);
83-
} else if (preferences.get(JabRefPreferences.USE_PDF_READER).equals(usePDFSumatraCommandProperty.getValue())) {
84-
usePDFSumatraProperty.setValue(true);
85-
}
86-
}
87-
8876
useFileBrowserDefaultProperty.setValue(preferences.getBoolean(JabRefPreferences.USE_DEFAULT_FILE_BROWSER_APPLICATION));
8977
useFileBrowserSpecialProperty.setValue(!preferences.getBoolean(JabRefPreferences.USE_DEFAULT_FILE_BROWSER_APPLICATION));
9078
useFileBrowserSpecialCommandProperty.setValue(preferences.get(JabRefPreferences.FILE_BROWSER_COMMAND));
@@ -100,16 +88,6 @@ public void storeSettings() {
10088
preferences.putBoolean(JabRefPreferences.USE_DEFAULT_CONSOLE_APPLICATION, useTerminalDefaultProperty.getValue());
10189
preferences.put(JabRefPreferences.CONSOLE_COMMAND, useTerminalCommandProperty.getValue());
10290

103-
preferences.put(JabRefPreferences.ADOBE_ACROBAT_COMMAND, usePDFAcrobatCommandProperty.getValue());
104-
if (OS.WINDOWS) {
105-
preferences.put(JabRefPreferences.SUMATRA_PDF_COMMAND, usePDFSumatraCommandProperty.getValue());
106-
}
107-
if (usePDFAcrobatProperty.getValue()) {
108-
preferences.put(JabRefPreferences.USE_PDF_READER, usePDFAcrobatCommandProperty.getValue());
109-
} else if (usePDFSumatraProperty.getValue()) {
110-
preferences.put(JabRefPreferences.USE_PDF_READER, usePDFSumatraCommandProperty.getValue());
111-
}
112-
11391
preferences.putBoolean(JabRefPreferences.USE_DEFAULT_FILE_BROWSER_APPLICATION, useFileBrowserDefaultProperty.getValue());
11492
if (StringUtil.isNotBlank(useFileBrowserSpecialCommandProperty.getValue())) {
11593
preferences.put(JabRefPreferences.FILE_BROWSER_COMMAND, useFileBrowserSpecialCommandProperty.getValue());

‎src/main/java/org/jabref/gui/preferences/FileTabView.java

+4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import org.jabref.gui.actions.StandardActions;
1414
import org.jabref.gui.help.HelpAction;
1515
import org.jabref.gui.util.IconValidationDecorator;
16+
import org.jabref.gui.util.ViewModelListCellFactory;
1617
import org.jabref.logic.help.HelpFile;
1718
import org.jabref.logic.l10n.Localization;
1819
import org.jabref.preferences.JabRefPreferences;
@@ -68,6 +69,9 @@ public void initialize() {
6869
resolveStringsAll.selectedProperty().bindBidirectional(viewModel.resolveStringsAllProperty());
6970
resolveStringsExcept.textProperty().bindBidirectional(viewModel.resolvStringsExceptProperty());
7071
resolveStringsExcept.disableProperty().bind(resolveStringsAll.selectedProperty().not());
72+
new ViewModelListCellFactory<NewLineSeparator>()
73+
.withText(NewLineSeparator::getDisplayName)
74+
.install(newLineSeparator);
7175
newLineSeparator.itemsProperty().bind(viewModel.newLineSeparatorListProperty());
7276
newLineSeparator.valueProperty().bindBidirectional(viewModel.selectedNewLineSeparatorProperty());
7377
alwaysReformatBib.selectedProperty().bindBidirectional(viewModel.alwaysReformatBibProperty());

‎src/main/java/org/jabref/gui/preferences/GeneralTab.fxml

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<CheckBox fx:id="allowIntegerEdition" text="%Allow integers in 'edition' field in BibTeX mode"/>
4040
<CheckBox fx:id="memoryStickMode"
4141
text="%Load and Save preferences from/to jabref.xml on start-up (memory stick mode)"/>
42-
<CheckBox fx:id="collectTelemetry" text="%Collect and share telemetry data to help improve JabRef."/>
42+
<CheckBox fx:id="collectTelemetry" text="%Collect and share telemetry data to help improve JabRef"/>
4343
<CheckBox fx:id="showAdvancedHints"
4444
text="%Show advanced hints (i.e. helpful tooltips, suggestions and explanation)"/>
4545

0 commit comments

Comments
 (0)