Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Source of Truth #511

Closed
HuanzhiMao opened this issue Jul 8, 2024 · 1 comment · Fixed by #644
Closed

Single Source of Truth #511

HuanzhiMao opened this issue Jul 8, 2024 · 1 comment · Fixed by #644
Labels
BFCL-General General BFCL Issue good first issue Good for newcomers

Comments

@HuanzhiMao
Copy link
Collaborator

The mapping from test category name to test file path is repeated three times, which is bad.

  • test_files in eval_data_compilation.py
  • test_categories in openfunctions_evaluation.py
  • TEST_CATEGORIES in model_handler/constant.py
@HuanzhiMao HuanzhiMao added good first issue Good for newcomers BFCL-General General BFCL Issue labels Jul 8, 2024
@HuanzhiMao HuanzhiMao linked a pull request Oct 16, 2024 that will close this issue
[BFCL] BFCL v3 #644
Merged
@HuanzhiMao
Copy link
Collaborator Author

Addressed in #644.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BFCL-General General BFCL Issue good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BFCL] BFCL v3 HuanzhiMao/gorilla
1 participant
@HuanzhiMao