Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack days (36): PoC of generating source maps #4135

Closed

Conversation

jamesvidler
Copy link
Contributor

@jamesvidler jamesvidler commented Jun 27, 2024

See https://docs.google.com/document/d/1iqd_oyvC-gigP3knw7TIkMJ4L_QO_dqDbusQ_dQ78-s/edit

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.62% (+0.11% 🔼)
7913/10897
🟡 Branches
69.39% (+0.05% 🔼)
3885/5599
🟡 Functions
71.33% (+0.03% 🔼)
2077/2912
🟡 Lines
72.95% (+0.12% 🔼)
7478/10251

Test suite run success

1805 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from cfd7059

@jamesvidler jamesvidler changed the title PoC of generating source maps Hack days 36: PoC of generating source maps Jun 28, 2024
@jamesvidler jamesvidler changed the title Hack days 36: PoC of generating source maps Hack days (36): PoC of generating source maps Jun 28, 2024
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@jamesvidler
Copy link
Contributor Author

/snapit

@jamesvidler
Copy link
Contributor Author

This is still relevant. We are planning to ship this along with some updates in core to handle authenticated sourcemaps. We also intend to use snapit for tophatting this change.

@jamesvidler jamesvidler reopened this Aug 6, 2024
@jamesvidler
Copy link
Contributor Author

/snapit

@jamesvidler jamesvidler force-pushed the jkv/create-source-maps-ui-extensions-deploy branch from 4abc030 to cfd7059 Compare August 6, 2024 20:48
@jamesvidler
Copy link
Contributor Author

/snapit

Copy link
Contributor

github-actions bot commented Aug 6, 2024

🫰✨ Thanks @jamesvidler! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g shopify@0.0.0-snapshot-20240806204953

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant