[Bug]: theme push is very slow in versions with the new colorful upload UI #4210
Comments
both my old PC and new PC are under the same network environment and using the proxy software Clash with TUN mode enabled. |
lucyxiang
added
Area: @shopify/theme
|
Hey @BearKid, are you deleting your theme between these You can test the TypeScript implementation (new colorful UI) vs Ruby implementation (what older CLI versions use) with the |
|
@lucyxiang thx for your reply.
I tested three times with
|
|
Continuing from the previous comment.
On my new PC, the 16 uploaded files under shopify/cli@3.64.0 |
|
Thank you for the details @BearKid, I'll bring this back to the team. If you are comfortable sharing the exact theme projects you're working with, that'll help us investigate, you can email them to me at lucy.xiang@shopify.com. |
Thx, I re-test in a clean project (created by No luck, the cli without 2024-07-23T09:20:32.091Z: Analytics event sent:
{
"command": "theme push",
"time_start": 1721726390869,
"time_end": 1721726431007,
"total_time": 40138,
"success": true,
"cli_version": "3.64.0",
"ruby_version": "3.1.2",
"node_version": "22.4.1",
"is_employee": false,
"uname": "windows amd64",
"env_ci": false,
"env_plugin_installed_any_custom": false,
"env_plugin_installed_shopify": "[\"@shopify/cli\"]",
"env_shell": "cmd.exe",
"env_device_id": "965d14299bfe08715bf65c528f0f88481987ba6d",
"env_cloud": "localhost",
"env_package_manager": "unknown",
"env_is_global": true,
"cmd_app_warning_api_key_deprecation_displayed": false,
"cmd_all_timing_network_ms": 37321,
"cmd_all_timing_prompts_ms": 0,
"cmd_all_launcher": "unknown",
"cmd_all_topic": "theme",
"cmd_all_plugin": "@shopify/cli",
"cmd_all_force": false,
"cmd_all_verbose": true,
"cmd_all_path_override": true,
"cmd_all_path_override_hash": "fc9241ef609882b9d6bfbf1494a2267be28512fe",
"cmd_all_timing_active_ms": 2816,
"cmd_all_exit": "ok",
"args": "-d --verbose --store xxx-dev.myshopify.com",
"env_plugin_installed_all": "[\"@shopify/cli\"]",
"metadata": "{\"extraPublic\":{},\"extraSensitive\":{}}"
}after that, I run twice with |
|
👋🏻 Hi all, thanks so much for your reports and logs. We are tracking this in some upcoming work, so hope to be able to resolve these issues soon. Thanks for your patience with this one |
|
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
|
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. P.S. You can learn more about why we stale issues here. |
|
We are having the same experience and it hits our productivity quite a bit. Together with the 3.69.x introduced inability to build when triggered by github on cloud environments (crash due to prompting which doesnt work on remote), I feel the shopify cli is getting worse by the version. We will stay with an old version since it is much more effective and stable. |
|
Thank you all for the updates! If this is still occurring, it would help to know which files are getting re-uploaded each time.
Would you mind sharing the command you're running in github, and what prompt is failing? |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Theme
Expected behavior
I expect
shopify theme push -din @shopify/cli@3.64.0 should complete in no more than 5s, should be same as @shopify/cli@3.47.5.Actual behavior
I found that v3.56.x ~ v3.64.0 (the latest version at this moment) is very slow when uploading the theme files using
shopify theme push -d.I tested cli 3.47.x ~ 3.53.x,
shopify theme push -dis far more faster than the new versions, taking no more than 5s.Intuitively, the versions with the colorful upload progress bar are slow, and the versions with the old style upload progress bar are faster.
Below is a more detail table
As you can see by the table above, my new PC doesn't run the old version of the CLI properly and I have to use the new version, so I'm desperate to find a solution to the slow uploads.
Verbose output
Reproduction steps
pnpm i -g @shopify/cli@3.64.0ornpm i -g @shopify/cli@3.64.0shopify theme push -d --store xxx.myshopify.comOperating System
Windows 10
Shopify CLI version (check your project's
package.jsonif you're not sure)3.64.0
Shell
Powersell
Node version (run
node -vif you're not sure)v22.4.1
What language and version are you using in your application?
No response
The text was updated successfully, but these errors were encountered: