-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Command theme dev doesn't show link to theme editor #4237
Comments
This was report on 14.11.2023 on the community forum: https://community.shopify.com/c/shopify-design/new-shopify-cli-is-not-giving-me-the-editor-link-in-linux/m-p/2313095 It's also a Linux user, so this problem might be restricted to Linux |
👋🏻 Hey @mdiniz, thanks for the report. What terminal are you using? The CLI will not render hyperlinks if the terminal does not support them. This behaviour you're seeing is expected for the CLI. |
closing as wont fix since this is expected behavior for the CLI |
@lukeh-shopify @mgmanzella I use xfce4-terminal 0.8.9.1. Hyperlinks are supported. On the "Verbose output" that I provided, the link "Share your theme preview" can be clicked as usual. Please reopen the issue as the current behaviour is not as expected. Thank you. |
👋 Hey @mdiniz, Terminal emulators like Kitty, which don't support hyperlinks, render Shopify CLI links like this: (as we may notice, the links are listed below -- they are still clickable, but the link needs to explicitly appear there to work) Terminal emulators like the one on VS Code, which support hyperlinks, display clickable links. These links are not rendered, but users can interact with them, as shown in the GIF below: Please let us know if we're missing something. Thank you for reporting this! |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Theme
Expected behavior
When I run
shopify theme dev --store mystore.myshopify.com
, 3 links should be shown:Actual behavior
The 2nd link "Customize your theme at the theme editor" is not shown.
As a workaround I can see the theme ID as a parameter on the 3rd link, and then can create my only link like https://mystore.myshopify.com/admin/themes/1234567890/editor
On the verbose output below I set the shop URL as mystore.myshopify.com
Verbose output
Reproduction steps
shopify theme dev --store mystore.myshopify.com
Operating System
Ubuntu 20.04
Shopify CLI version (check your project's
package.json
if you're not sure)3.64.1
Shell
bash
Node version (run
node -v
if you're not sure)v20.16.0
What language and version are you using in your application?
Not applicable
The text was updated successfully, but these errors were encountered: