Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Disable toml file formatting when running shopify app dev #4249

Open
patryk-smc opened this issue Jul 30, 2024 · 12 comments
Open
Labels
Area: @shopify/app @shopify/app package issues stale-exempt If added, the PR/issue won't be closed by stale-bot Type: Enhancement New feature or request

Comments

@patryk-smc
Copy link

What area(s) will this request affect?

Running your code locally

What type of change do you want to see?

Substantial change to existing feature

Overview

Could you add an option to disable formatting when running shopify app dev? Or perhaps format it with the editor's default formatter?

Motivation

It formats differently than the Even Better TOML VScode extension - annoying.

@patryk-smc patryk-smc added the Type: Enhancement New feature or request label Jul 30, 2024
@gonzaloriestra
Copy link
Contributor

Thanks for the suggestion. Could you provide some examples of what's being formatted differently?

cc: @nickwesselman

@patryk-smc
Copy link
Author

@gonzaloriestra
here you go

Screenshot 2024-07-30 at 14 25 04@2x

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@patryk-smc
Copy link
Author

Still relevant and still annoying 😅

@isaacroldan isaacroldan added the Area: @shopify/app @shopify/app package issues label Sep 11, 2024
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@jagthedrummer
Copy link

Not stale. Stale bot sucks.

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@jagthedrummer
Copy link

Not stale. Please disable the stale bot. It makes it seem like you don't care to hear from people using your software.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@jagthedrummer
Copy link

STILL not stale. Please disable the sucky bot.

Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@jagthedrummer
Copy link

Not stale. And that bot still sucks.

@gonzaloriestra gonzaloriestra added the stale-exempt If added, the PR/issue won't be closed by stale-bot label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/app @shopify/app package issues stale-exempt If added, the PR/issue won't be closed by stale-bot Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants