Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HostThemeManager and HostThemeManager into themes app extensions utilities directory #4328

Closed
jamesmengo opened this issue Aug 14, 2024 · 0 comments · Fixed by #4327
Closed

Move HostThemeManager and HostThemeManager into themes app extensions utilities directory #4328

jamesmengo opened this issue Aug 14, 2024 · 0 comments · Fixed by #4327
Assignees
@jamesmengo
Labels
#gsd:40767 Fortify local development experience for Liquid themes

Comments

@jamesmengo
Copy link
Contributor 

          Thank you, @jamesmengo! The PR is in excellent shape and works as expected!

Just one minor comment, which we may apply here or in a following PR (when we introduce the other modules that handle the development server): I believe we could move the host-theme-watcher and the host-theme-manager to the packages/app/src/cli/utilities/extensions/theme/ directory :)

Thanks again for this PR!

Originally posted by @karreiro in #4156 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmengo jamesmengo

Labels
#gsd:40767 Fortify local development experience for Liquid themes
Projects
None yet
Milestone
No milestone
1 participant
@jamesmengo