Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cli-kit themes logic into the themes package #4769

Open
jamesmengo opened this issue Oct 29, 2024 · 2 comments
Open

Move cli-kit themes logic into the themes package #4769

jamesmengo opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues good first issue Good for newcomers important second highest severity for theme related bug tech debt Liquid SF (tech debt)

Comments

@jamesmengo
Copy link
Contributor

  • This includes moving the existing code into packages/theme, and ensuring that the utilities and functions needed in the app package are served.

  • Part of this will also require investigating cli-kit dependancies to ensure that we aren't breaking any existing flows

@jamesmengo jamesmengo added Area: @shopify/theme @shopify/theme package issues tech debt Liquid SF (tech debt) good first issue Good for newcomers labels Oct 29, 2024
@jeffreyguenther
Copy link

Is there a possibility that the theme package might be made public again?

Moving the theme utilities into packages/theme is the opposite direction I was hoping things would go. The cli-kit is the main package still being published.

CLI plugin developers could really use access to the theme interaction code that's been written. I've been advocating for this for a while and not really seeing a clear path forward.

@jamesmengo jamesmengo added the important second highest severity for theme related bug label Nov 5, 2024
@jamesmengo jamesmengo self-assigned this Nov 5, 2024
@jamesmengo
Copy link
Contributor Author

Hey @jeffreyguenther

Sorry about that - let me follow this up and get back to you.
I recall this conversation and the plans we had made to expose certain functionality programatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues good first issue Good for newcomers important second highest severity for theme related bug tech debt Liquid SF (tech debt)
Projects
None yet
Development

No branches or pull requests

2 participants