Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Check Ruby support before creating theme app extension #4783

Open
2 tasks done
byrichardpowell opened this issue Nov 1, 2024 · 2 comments
Open
2 tasks done
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working

Comments

@byrichardpowell
Copy link
Contributor

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Extension

Expected behavior

When creating a theme extension the version of Ruby should be checked. If the correct version is not present, the theme extension should not be created.

Actual behavior

Creating a theme extension with an incompatible version of Ruby will succeed.

Note: The ruby version is only checked when running shopify app dev. It should be checked earlier so we don't generate files which won't be supported.

Verbose output

NA

Reproduction steps

  1. Setup your system with a version of Ruby that is not supported by theme extensions
  2. shopify app generate extension
  3. Select a theme extension
  4. The command will succeed. It should fail.

Operating System

Mac OS

Shopify CLI version (check your project's package.json if you're not sure)

Any

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@byrichardpowell byrichardpowell added the Type: Bug Something isn't working label Nov 1, 2024
@amcaplan
Copy link
Contributor

amcaplan commented Nov 3, 2024

@byrichardpowell does this issue make sense if we've just removed Ruby from the CLI (to be applied in 3.70)?

@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Nov 6, 2024
@jamesmengo
Copy link
Contributor

👋🏻 Checking in from themes

@byrichardpowell could you let me know if this is still happening on the latest version?

This should not be happening on the latest release, but as Ariel mentioned, with the complete removal of Ruby in 3.70 I'd expect this to be resolved moving forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants