Clarify how to attach to a custom deprecator #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using this gem on a repository that isn't using Rails. I migrated from `ActiveSupport::Deprecation.warn(...)` to `ActiveSupport::Deprecation.new.warn()` and it was not logging any deprecation call. The reason is that, by default , [the gem attaches to :rails](https://github.com/Shopify/deprecation_toolkit/blob/953c26d48a75edcf844c97437f2596d414a7bebf/lib/deprecation_toolkit.rb#L37-L39). This PR clarifies in the README that if you're not using Rails then you should set `attach_to` correctly.
etiennebarrie
force-pushed
the
ignacio-chiazzo-patch-1
branch
from
8f37450 to
36fd273
Compare
etiennebarrie
changed the title
|
Tweaked the wording a bit, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this gem on a repository that doesn't use Rails. I migrated from ActiveSupport::Deprecation.warn(...) to ActiveSupport::Deprecation.new.warn(), and it did not log any deprecation calls.
The reason is that, by default, the gem attaches to :rails.
This PR clarifies in the README that if you're not using Rails, you should set attach_to correctly.
Example: