Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ErrorHandler in ferry #284

Open
Manan007224 opened this issue May 13, 2021 · 1 comment
Open

refactor ErrorHandler in ferry #284

Manan007224 opened this issue May 13, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Manan007224
Copy link
Contributor

Currently copydb and sharding are also calling ErrorHandler on ferry to repor the error to the ErrorCallback object whenever any errors occur before the ferry starts running, and after that ferry internally calls the ErrorHandler when any of the components in ferry (DataWriter, BinlogStreamer etc) fails. This is not a desirable design as we should not be calling the ErrorHandler from copydb and sharding. This might require some refactoring on how ErrorHandler works and which component owns this object (copydb. sharding or ferry itself).
@Manan007224 Manan007224 added enhancement New feature or request good first issue Good for newcomers labels May 13, 2021
@varks
Copy link

varks commented Aug 14, 2023

@Manan007224 would like to help on this. Is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varks @Manan007224