Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #40

Closed
junosuarez opened this issue Jan 5, 2017 · 5 comments
Closed

Changelog #40

junosuarez opened this issue Jan 5, 2017 · 5 comments

Comments

@junosuarez
Copy link

I just saw that version 0.3 was released- congratulations! Is there a list of what has changed? I would recommend also checking it into the repo in a changelog file.

Cheers

@dylanahsmith
Copy link
Contributor

v0.2.5...v0.3.0 for a full list of changes. #36 is a breaking change but should only affect test code. The main feature is support for https://github.com/rmosolgo/graphql-ruby/blob/master/guides/schema/lazy_execution.md which was released after the last release of this library, so I should update the README to recommend the use of that feature instead of the graphql-batch execution strategies.

@sjchmiela
Copy link
Contributor

recommend the use of that feature instead of the graphql-batch execution strategies.

and graphql-ruby recommends use of graphql-batch…

The example above is simple and has some shortcomings. Consider the graphql-batch gem for a robust solution to batched resolution.

Which should one use then?

@dylanahsmith
Copy link
Contributor

I'm not saying to stop using graphql-batch, just that instead of doing

MySchema = GraphQL::Schema.define do
  query MyQueryType
end
MySchema.query_execution_strategy = GraphQL::Batch::ExecutionStrategy
MySchema.mutation_execution_strategy = GraphQL::Batch::MutationExecutionStrategy

you would do

MySchema = GraphQL::Schema.define do
  query MyQueryType
  lazy_resolve(Promise, :sync)
  instrument(:query, GraphQL::Batch::Setup)
end

GraphQL::Batch::ExecutionStrategy and GraphQL::Batch::MutationExecutionStrategy will be deprecated then removed since they rely on method overrides which make them fragile to changes in graphql-ruby

@sjchmiela
Copy link
Contributor

Ah, all right, that I couldn't even think of. :)

@junosuarez
Copy link
Author

Ah, I didn't even think to use GitHub's compare :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants