Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping Items #102

Open
4 of 5 tasks
sambostock opened this issue Jul 15, 2021 · 0 comments
Open
4 of 5 tasks

Housekeeping Items #102

sambostock opened this issue Jul 15, 2021 · 0 comments

Comments

@sambostock
Copy link
Contributor

sambostock commented Jul 15, 2021

There are a couple things we could to improve the gem:

  • Specify a required_ruby_version in gemspec
    This makes it clear to consumers which versions of Ruby we commit to supporting.
    • We only test against Ruby 2.5 and greater, so it seems reasonable that it should be at least >= 2.5
      • However, the Ruby 2.5 EOL date was 2021-03-31, so maybe we should use >= 2.6 and stop testing against 2.5?
  • Bump the Rubocop TargetRubyVersion to match the above (it is currently 2.4.4, whose EOL date was 2020-03-31
  • Remove Gemfile.lock from .gitignore, as per this post on the Bundler blog
    • Setup Dependabot to keep dependencies up to date.
      • Does Dependabot support our multiple gemfiles?
  • Add internal Shopify owners to the gem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant