-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more resource types #46
Comments
I've now seen StatefulSet, DaemonSet and Secret 😱 in use by our apps (the latter for a case that should be using a configmap). Some people have also tested HPAs, but I'm not sure anyone is using them for real yet. |
Maybe a default fallback handler that does a fire-and-forget |
That's exactly what already happens (and it logs a warning that it did so). 😄 |
Daemon Sets also use |
+1 for HPA support |
HPA support has been merged #305. |
With HPA in, I think we can actually close this. I don't see any unsupported resources left that actually report a status, i.e. where supporting them explicitly would actually improve deploy behaviour. For example, there are a bunch of policy objects (LimitRange, PodSecurityPolicy, Role, RoleBinding...) we don't model, but they're typically controller-managed, and we could trivially add them on-demand if others say they do want to use kubernetes-deploy to manage them. Adding resources like those effectively just suppresses the warning. |
We only selected a few that our own apps commonly use for the initial rollout. Currently unrecognized types will be kubectl applied and a warning will be logged about the fact that the script does not know how to check whether they actually came up.
The text was updated successfully, but these errors were encountered: