[draft] Fix CI errors #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayana-s
requested review from
kn100 and
timothysmith0609
and removed request for
a team
ayana-s
force-pushed
the
fix-minitest-ci-errors
branch
from
4275668
to
b566e98
Compare
Merged
|
Closing in favour of #929. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[please ignore this for now - still testing]
What are you trying to accomplish with this PR?
krane's CI tests are failing with
Mocha::ExpectationErrorFactory.exception_class = ::MiniTest::Assertion. Examples here. We think this is becausemochais out-of-date.How is this accomplished?
mochahas fixed this error^ in a more recent version (2.1.0). This PR bumps mocha's version.What could go wrong?
...